code review 40340043: crypto/x509: fix behaviour of KeyUsageAny.

crypto/x509: fix behaviour of KeyUsageAny.

(Reporter wasn't able to provide a certificate chain that uses this
feature for testing.)

Fixes issue 6831

[agl1, 2013-12-10 18:00:19]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go/

[bradfitz, 2013-12-10 18:15:44]

LGTM
 On Dec 10, 2013 10:00 PM, <agl@golang.org> wrote:

> Reviewers: golang-dev1,
>
> Message:
> Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change to
> https://code.google.com/p/go/
>
>
> Description:
> crypto/x509: fix behaviour of KeyUsageAny.
>
> (Reporter wasn't able to provide a certificate chain that uses this
> feature for testing.)
>
> Fixes 6831.
>
> Please review this at https://codereview.appspot.com/40340043/
>
> Affected files (+2, -1 lines):
>   M src/pkg/crypto/x509/verify.go
>
>
> Index: src/pkg/crypto/x509/verify.go
> ===================================================================
> --- a/src/pkg/crypto/x509/verify.go
> +++ b/src/pkg/crypto/x509/verify.go
> @@ -425,6 +425,7 @@
>         // by each certificate. If we cross out all the usages, then the
> chain
>         // is unacceptable.
>
> +NextCert:
>         for i := len(chain) - 1; i >= 0; i-- {
>                 cert := chain[i]
>                 if len(cert.ExtKeyUsage) == 0 &&
> len(cert.UnknownExtKeyUsage) == 0 {
> @@ -435,7 +436,7 @@
>                 for _, usage := range cert.ExtKeyUsage {
>                         if usage == ExtKeyUsageAny {
>                                 // The certificate is explicitly good for
> any usage.
> -                               continue
> +                               continue NextCert
>                         }
>                 }
>
>
>
> --
>
> ---You received this message because you are subscribed to the Google
> Groups "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-dev+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
>

[r, 2013-12-10 18:40:01]

Change CL to

Fixes issue 6831

-rob

[agl1, 2013-12-10 18:41:31]

On 2013/12/10 18:40:01, r wrote:
> Fixes issue 6831

Done. Thanks.

[r, 2013-12-10 18:47:41]

LGTM

[agl1, 2013-12-10 19:06:33]

*** Submitted as https://code.google.com/p/go/source/detail?r=74fcda1034ed ***

crypto/x509: fix behaviour of KeyUsageAny.

(Reporter wasn't able to provide a certificate chain that uses this
feature for testing.)

Fixes issue 6831

R=golang-dev, bradfitz, r
CC=golang-dev
https://codereview.appspot.com/40340043