Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1470)

Issue 4023042: Support withKey element in Docs ACL feed.

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 3 months ago by dglasser
Modified:
13 years, 3 months ago
Reviewers:
glasser, jcgregorio
CC:
gdata-python-client-library-contributors_googlegroups.com
Visibility:
Public.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -0 lines) Patch
M src/gdata/acl/data.py View 1 chunk +8 lines, -0 lines 0 comments Download
M src/gdata/test_data.py View 1 chunk +9 lines, -0 lines 0 comments Download
M tests/gdata_tests/data_smoke_test.py View 1 chunk +1 line, -0 lines 0 comments Download
M tests/gdata_tests/docs/data_test.py View 2 chunks +36 lines, -0 lines 0 comments Download

Messages

Total messages: 5
dglasser
13 years, 3 months ago (2011-01-18 21:20:32 UTC) #1
jcgregorio
LGTM Can you also add tests against the live service (in another CL)? Thanks, -joe
13 years, 3 months ago (2011-01-19 20:02:11 UTC) #2
glasser_davidglasser.net
OK. Though it's sort of undocumented that you can *write* this property at all (if ...
13 years, 3 months ago (2011-01-19 20:07:01 UTC) #3
jcgregorio
If it's that useful then it will get used, so having tests would be good. ...
13 years, 3 months ago (2011-01-19 20:09:26 UTC) #4
jcgregorio
13 years, 3 months ago (2011-01-25 13:20:11 UTC) #5
Submitted at 0437cfb505.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b