Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2213)

Issue 40190043: Add the ability to run local browser tests.

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 4 months ago by benji
Modified:
10 years, 4 months ago
Reviewers:
mp+198410
Visibility:
Public.

Description

Add the ability to run local browser tests. Some existing tests were moved from charm-requiring tests to local browser tests. https://code.launchpad.net/~benji/juju-gui/sandboxify-tests/+merge/198410 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 8
Unified diffs Side-by-side diffs Delta from patch set Stats (+131 lines, -74 lines) Patch
M HACKING View 1 chunk +1 line, -1 line 0 comments Download
M Makefile View 3 chunks +30 lines, -5 lines 3 comments Download
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M test/browser.py View 2 chunks +1 line, -2 lines 1 comment Download
A test/test_browser.py View 1 chunk +95 lines, -0 lines 1 comment Download
M test/test_browser_errors.py View 0 chunks +-1 lines, --1 lines 0 comments Download
M test/test_charm_running.py View 3 chunks +2 lines, -67 lines 3 comments Download
M test/test_deploy_charm_for_testing.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 1
benji
10 years, 4 months ago (2013-12-10 15:50:31 UTC) #1
Pre-review comments.

https://codereview.appspot.com/40190043/diff/1/Makefile
File Makefile (right):

https://codereview.appspot.com/40190043/diff/1/Makefile#newcode408
Makefile:408: # of this target when called by lbox.  Please do not change.
Typo fix, I think.

https://codereview.appspot.com/40190043/diff/1/Makefile#newcode445
Makefile:445: PYTHONPATH=lib virtualenv/bin/python test/test_websocketreplay.py
We were using the system Python here.

https://codereview.appspot.com/40190043/diff/1/Makefile#newcode458
Makefile:458: # Wait for the display to be accessible.
Avoid racing with Xvfb to start up.

https://codereview.appspot.com/40190043/diff/1/test/browser.py
File test/browser.py (left):

https://codereview.appspot.com/40190043/diff/1/test/browser.py#oldcode214
test/browser.py:214: printerr('* Platform: local
{}'.format(get_platform(driver)))
This was annoying and non-useful.

https://codereview.appspot.com/40190043/diff/1/test/test_browser.py
File test/test_browser.py (right):

https://codereview.appspot.com/40190043/diff/1/test/test_browser.py#newcode1
test/test_browser.py:1: # This file is part of the Juju GUI, which lets users
view and manage Juju
These tests were moved here, unchanged.

https://codereview.appspot.com/40190043/diff/1/test/test_charm_running.py
File test/test_charm_running.py (left):

https://codereview.appspot.com/40190043/diff/1/test/test_charm_running.py#old...
test/test_charm_running.py:25: class TestBasics(browser.TestCase):
These were moved elsewhere.

https://codereview.appspot.com/40190043/diff/1/test/test_charm_running.py#old...
test/test_charm_running.py:277: class TestAuthentication(browser.TestCase):
Moved.

https://codereview.appspot.com/40190043/diff/1/test/test_charm_running.py
File test/test_charm_running.py (right):

https://codereview.appspot.com/40190043/diff/1/test/test_charm_running.py#new...
test/test_charm_running.py:192: self.deploy('mysql')
This change made the tests start working when the GUI is not run from a charm
(as in the sandbox).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b