Issue 4001048: code review 4001048: log: rename Exit* to Fatal*

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4001048: code review 4001048: log: rename Exit* to Fatal* (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 1 month ago by r

Modified:
14 years, 1 month ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

log: rename Exit* to Fatal* This aligns the naming scheme with the testing package and also lets govet work on more logging calls.

Patch Set 1 #

Patch Set 2 : code review 4001048: log: rename Exit* to Fatal* #

Created: 14 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+77 lines, -77 lines)			Patch
M	doc/codelab/wiki/get.go	View		3 chunks	+4 lines, -4 lines	0 comments	Download
M	doc/codelab/wiki/srcextract.go	View		1 chunk	+1 line, -1 line	0 comments	Download
M	doc/effective_go.html	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	doc/htmlgen.go	View		1 chunk	+1 line, -1 line	0 comments	Download
M	misc/dashboard/builder/main.go	View		1 chunk	+5 lines, -5 lines	0 comments	Download
M	misc/goplay/goplay.go	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/cmd/godoc/godoc.go	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download
M	src/cmd/godoc/main.go	View		5 chunks	+5 lines, -5 lines	0 comments	Download
M	src/pkg/exec/lp_test.go	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/http/server.go	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/pkg/log/log.go	View		3 chunks	+14 lines, -14 lines	0 comments	Download
M	src/pkg/netchan/export.go	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/netchan/import.go	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/pkg/rpc/server.go	View		5 chunks	+5 lines, -5 lines	0 comments	Download
M	src/pkg/rpc/server_test.go	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/syslog/syslog_test.go	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/unicode/maketables.go	View		14 chunks	+25 lines, -25 lines	0 comments	Download
M	src/pkg/websocket/websocket_test.go	View		1 chunk	+1 line, -1 line	0 comments	Download
M	test/garbage/parser.go	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 1 month ago (2011-02-01 20:15:22 UTC) #1

14 years, 1 month ago (2011-02-01 20:47:38 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=244f63f88b27 ***

log: rename Exit* to Fatal*
This aligns the naming scheme with the testing package and
also lets govet work on more logging calls.

R=rsc
CC=golang-dev
http://codereview.appspot.com/4001048

Expand All Messages | Collapse All Messages