Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(956)

Side by Side Diff: misc/dashboard/builder/main.go

Issue 4001048: code review 4001048: log: rename Exit* to Fatal* (Closed)
Patch Set: code review 4001048: log: rename Exit* to Fatal* Created 14 years, 1 month ago
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.
Jump to:
View unified diff | Download patch
« no previous file with comments | « doc/htmlgen.go ('k') | misc/goplay/goplay.go » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 package main 1 package main
2 2
3 import ( 3 import (
4 "container/vector" 4 "container/vector"
5 "flag" 5 "flag"
6 "fmt" 6 "fmt"
7 "io/ioutil" 7 "io/ioutil"
8 "log" 8 "log"
9 "os" 9 "os"
10 "path" 10 "path"
(...skipping 48 matching lines...) Expand 10 before | Expand all | Expand 10 after
59 } 59 }
60 flag.Parse() 60 flag.Parse()
61 if len(flag.Args()) == 0 { 61 if len(flag.Args()) == 0 {
62 flag.Usage() 62 flag.Usage()
63 } 63 }
64 goroot = path.Join(*buildroot, "goroot") 64 goroot = path.Join(*buildroot, "goroot")
65 builders := make([]*Builder, len(flag.Args())) 65 builders := make([]*Builder, len(flag.Args()))
66 for i, builder := range flag.Args() { 66 for i, builder := range flag.Args() {
67 b, err := NewBuilder(builder) 67 b, err := NewBuilder(builder)
68 if err != nil { 68 if err != nil {
69 » » » log.Exit(err) 69 » » » log.Fatal(err)
70 } 70 }
71 builders[i] = b 71 builders[i] = b
72 } 72 }
73 if err := os.RemoveAll(*buildroot); err != nil { 73 if err := os.RemoveAll(*buildroot); err != nil {
74 » » log.Exitf("Error removing build root (%s): %s", *buildroot, err) 74 » » log.Fatalf("Error removing build root (%s): %s", *buildroot, err )
75 } 75 }
76 if err := os.Mkdir(*buildroot, mkdirPerm); err != nil { 76 if err := os.Mkdir(*buildroot, mkdirPerm); err != nil {
77 » » log.Exitf("Error making build root (%s): %s", *buildroot, err) 77 » » log.Fatalf("Error making build root (%s): %s", *buildroot, err)
78 } 78 }
79 if err := run(nil, *buildroot, "hg", "clone", hgUrl, goroot); err != nil { 79 if err := run(nil, *buildroot, "hg", "clone", hgUrl, goroot); err != nil {
80 » » log.Exit("Error cloning repository:", err) 80 » » log.Fatal("Error cloning repository:", err)
81 } 81 }
82 // if specified, build revision and return 82 // if specified, build revision and return
83 if *buildRevision != "" { 83 if *buildRevision != "" {
84 c, err := getCommit(*buildRevision) 84 c, err := getCommit(*buildRevision)
85 if err != nil { 85 if err != nil {
86 » » » log.Exit("Error finding revision: ", err) 86 » » » log.Fatal("Error finding revision: ", err)
87 } 87 }
88 for _, b := range builders { 88 for _, b := range builders {
89 if err := b.buildCommit(c); err != nil { 89 if err := b.buildCommit(c); err != nil {
90 log.Println(err) 90 log.Println(err)
91 } 91 }
92 runQueuedBenchmark() 92 runQueuedBenchmark()
93 } 93 }
94 return 94 return
95 } 95 }
96 // check for new commits and build them 96 // check for new commits and build them
(...skipping 234 matching lines...) Expand 10 before | Expand all | Expand 10 after
331 331
332 func isDirectory(name string) bool { 332 func isDirectory(name string) bool {
333 s, err := os.Stat(name) 333 s, err := os.Stat(name)
334 return err == nil && s.IsDirectory() 334 return err == nil && s.IsDirectory()
335 } 335 }
336 336
337 func isFile(name string) bool { 337 func isFile(name string) bool {
338 s, err := os.Stat(name) 338 s, err := os.Stat(name)
339 return err == nil && (s.IsRegular() || s.IsSymlink()) 339 return err == nil && (s.IsRegular() || s.IsSymlink())
340 } 340 }
OLDNEW
« no previous file with comments | « doc/htmlgen.go ('k') | misc/goplay/goplay.go » ('j') | no next file with comments »

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b