Issue 4000050: Fix typo, make whitelistAll only affect the props not already whitelisted

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4000050: Fix typo, make whitelistAll only affect the props not already whitelisted (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 2 months ago by metaweta

Modified:
15 years, 2 months ago

Reviewers:
Jasvir

CC:
google-caja-discuss_googlegroups.com

Base URL:
http://google-caja.googlecode.com/svn/trunk/

Visibility:
Public.

Description

Changed an s to a g. It worked in many instances because the getter had already been marked as safe. Also made whitelistAll only affect those properties of the given object that had not already been whitelisted.

Patch Set 1 #

Created: 15 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -4 lines)			Patch
	M	build.xml	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	src/com/google/caja/es53.js	View		2 chunks	+6 lines, -3 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

LGTM

Expand All Messages | Collapse All Messages