code review 4000046: bytes: Add Buffer.ReadBytes, Buffer.ReadString

bytes: Add Buffer.ReadBytes, Buffer.ReadString

[eds, 2011-01-26 07:20:22]

Hello golang-dev@googlegroups.com,

I'd like you to review this change.

[r, 2011-01-26 18:30:11]

http://codereview.appspot.com/4000046/diff/5001/src/pkg/bytes/buffer.go
File src/pkg/bytes/buffer.go (right):

http://codereview.appspot.com/4000046/diff/5001/src/pkg/bytes/buffer.go#newco...
src/pkg/bytes/buffer.go:308: // ReadBytes returns err != nil if and only if line
does not end in delim.
here, below, and in the original comments in bufio, please
s/if line/if the line/
or - because this is the first mention of the word 'line' - better would be
s/if line/if the returned data/
(the comment and the signature don't quite line up, but it's not too confusing 
so let's keep them separate)

http://codereview.appspot.com/4000046/diff/5001/src/pkg/bytes/buffer.go#newco...
src/pkg/bytes/buffer.go:326: func (b *Buffer) ReadString(delim byte) (line
string, err os.Error) {
i'm a little surprised to see delim is a byte, but i see it's the same as bufio.
not your problem.

http://codereview.appspot.com/4000046/diff/5001/src/pkg/bytes/buffer_test.go
File src/pkg/bytes/buffer_test.go (right):

http://codereview.appspot.com/4000046/diff/5001/src/pkg/bytes/buffer_test.go#...
src/pkg/bytes/buffer_test.go:371: t.Errorf("%d expected %q, %v got %q, %v", i,
test.expected, test.err, bytes, err)
you can drop the test number - it adds little and would look confusing in the
output

[eds, 2011-01-27 09:42:55]

Hello golang-dev@googlegroups.com, r (cc: golang-dev@googlegroups.com),

Please take another look.

[r, 2011-01-27 21:56:02]

LGTM

[r, 2011-01-27 22:00:36]

*** Submitted as http://code.google.com/p/go/source/detail?r=c2ab3fbc6b5f ***

bytes: Add Buffer.ReadBytes, Buffer.ReadString

R=golang-dev, r
CC=golang-dev
http://codereview.appspot.com/4000046

Committer: Rob Pike <r@golang.org>