code review 4000046: bytes: Add Buffer.ReadBytes, Buffer.ReadString

src/pkg/bytes/buffer_test.go

 // Copyright 2009 The Go Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style
 // license that can be found in the LICENSE file.
 
 package bytes_test
 
 import (
         . "bytes"
         "os"
         "rand"
@@ skipping 346 matching lines @@
 }{
         {err: os.EOF},
         {[]byte{}, 0, []byte{}, os.EOF},
         {[]byte("a\x00"), 0, []byte("a\x00"), nil},
         {[]byte("hello\x01world"), 1, []byte("hello\x01"), nil},
         {[]byte("foo\nbar"), 0, []byte("foo\nbar"), os.EOF},
         {[]byte("alpha beta gamma"), ' ', []byte("alpha "), nil},
 }
 
 func TestReadBytes(t *testing.T) {
-        for i, test := range readBytesTests {
+        for _, test := range readBytesTests {
                 buf := NewBuffer(test.buffer)
                 bytes, err := buf.ReadBytes(test.delim)
                 if !Equal(bytes, test.expected) || err != test.err {
-                        t.Errorf("%d expected %q, %v got %q, %v", i, test.expected, test.err, bytes, err)

[r, 2011/01/26 18:30:11]

you can drop the test number - it adds little and would look confusing in the
output

-                }
-        }
-}
+                        t.Errorf("expected %q, %v got %q, %v", test.expected, test.err, bytes, err)
+                }
+        }
+}