Issue 39970043: state: forced machine cleanup just sets Dead

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 39970043: state: forced machine cleanup just sets Dead

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 5 months ago by fwereade

Modified:
10 years, 5 months ago

Reviewers:
dimitern, mp+198356

Visibility:
Public.

Description

state: forced machine cleanup just sets Dead fixes lp:1259473 https://code.launchpad.net/~fwereade/juju-core/force-dead-machine/+merge/198356 (do not edit description out of merge proposal)

Patch Set 1 #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+35 lines, -19 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	cmd/juju/destroymachine_test.go	View	1 chunk	+4 lines, -2 lines	0 comments	Download
M	state/apiserver/client/client_test.go	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	state/cleanup.go	View	2 chunks	+15 lines, -5 lines	0 comments	Download
M	state/cleanup_test.go	View	3 chunks	+12 lines, -10 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

dimitern

I'm not quite sure how is this related to the provisioner safe-mode. If the safe-mode ...

10 years, 5 months ago (2013-12-10 09:52:40 UTC) #2

dimitern

10 years, 5 months ago (2013-12-10 10:14:51 UTC) #3

On 2013/12/10 09:52:40, dimitern wrote:
> I'm not quite sure how is this related to the provisioner safe-mode. If the
> safe-mode is off, it will work, but if it's not the machine and its instance
> will remain there and there's no way to remove them from the CLI. Perhaps we
> should have a cleanup-machines command that does the job of the provisioner,
> when safe-mode is true.

Ok, I stand corrected. safe-mode makes a distinction between "unknown" and
"stopped/dead" instances. So this LGTM.

Expand All Messages | Collapse All Messages