Issue 39910044: code review 39910044: reflect: remove length check for arrays in deepValueEqual

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 39910044: code review 39910044: reflect: remove length check for arrays in deepValueEqual (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 6 months ago by shawnps

Modified:
11 years, 6 months ago

Reviewers:
iant

CC:
golang-codereviews, iant

Visibility:
Public.

Description

reflect: remove length check for arrays in deepValueEqual

Patch Set 1 #

Patch Set 2 : diff -r 1e52bf0c539c https://code.google.com/p/go #

Patch Set 3 : diff -r 1e52bf0c539c https://code.google.com/p/go #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -3 lines)			Patch
	M	src/pkg/reflect/deepequal.go	View	1	1 chunk	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

shawnps

Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go

11 years, 6 months ago (2013-12-29 14:50:47 UTC) #1

shawnps

On 2013/12/29 14:50:47, shawnps wrote: > Hello mailto:golang-codereviews@googlegroups.com, > > I'd like you to review ...

11 years, 6 months ago (2013-12-29 14:53:17 UTC) #2

iant

11 years, 6 months ago (2013-12-29 19:05:36 UTC) #4

*** Submitted as https://code.google.com/p/go/source/detail?r=789a42298413 ***

reflect: remove length check for arrays in deepValueEqual

R=golang-codereviews, iant
CC=golang-codereviews
https://codereview.appspot.com/39910044

Committer: Ian Lance Taylor <iant@golang.org>

Expand All Messages | Collapse All Messages