code review 39560043: runtime: remove non-extern decls of runtime.goarm

runtime: remove non-extern decls of runtime.goarm

The linker is in charge of providing the one true declaration.

[rsc, 2013-12-09 23:59:55]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go/

[dave_cheney.net, 2013-12-10 00:02:08]

LGTM.

On Tue, Dec 10, 2013 at 10:59 AM,  <rsc@golang.org> wrote:
> Reviewers: golang-dev1,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://code.google.com/p/go/
>
>
> Description:
> runtime: remove non-extern decls of runtime.goarm
>
> The linker is in charge of providing the one true declaration.
>
> Please review this at https://codereview.appspot.com/39560043/
>
> Affected files (+2, -4 lines):
>   M src/cmd/5l/obj.c
>   M src/pkg/runtime/asm_arm.s
>   M src/pkg/runtime/os_linux_arm.c
>
>
> Index: src/cmd/5l/obj.c
> ===================================================================
> --- a/src/cmd/5l/obj.c
> +++ b/src/cmd/5l/obj.c
> @@ -95,6 +95,6 @@
>
>         // embed goarm to runtime.goarm
>         s = linklookup(ctxt, "runtime.goarm", 0);
> -       s->dupok = 1;
> +       s->type = SRODATA;
>         adduint8(ctxt, s, goarm);
>  }
> Index: src/pkg/runtime/asm_arm.s
> ===================================================================
> --- a/src/pkg/runtime/asm_arm.s
> +++ b/src/pkg/runtime/asm_arm.s
> @@ -89,8 +89,6 @@
>         WORD    $0xe1200071     // BKPT 0x0001
>         RET
>
> -GLOBL runtime·goarm(SB), $4
> -
>  TEXT runtime·asminit(SB),NOSPLIT,$0-0
>         // disable runfast (flush-to-zero) mode of vfp if runtime.goarm > 5
>         MOVW    runtime·goarm(SB), R11
> Index: src/pkg/runtime/os_linux_arm.c
> ===================================================================
> --- a/src/pkg/runtime/os_linux_arm.c
> +++ b/src/pkg/runtime/os_linux_arm.c
> @@ -16,7 +16,7 @@
>  static uint32 runtime·randomNumber;
>  uint8  runtime·armArch = 6;    // we default to ARMv6
>  uint32 runtime·hwcap;  // set by setup_auxv
> -uint8  runtime·goarm;  // set by 5l
> +extern uint8  runtime·goarm;   // set by 5l
>
>  void
>  runtime·checkgoarm(void)
>
>
> --
>
> ---You received this message because you are subscribed to the Google Groups
> "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-dev+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.

[r, 2013-12-10 00:04:24]

LGTM

[rsc, 2013-12-10 00:35:10]

*** Submitted as https://code.google.com/p/go/source/detail?r=59ac8ae2bf33 ***

runtime: remove non-extern decls of runtime.goarm

The linker is in charge of providing the one true declaration.

R=golang-dev, dave, r
CC=golang-dev
https://codereview.appspot.com/39560043