Issue 39440045: code review 39440045: freetype/truetype: fix bounding box calculation.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 39440045: code review 39440045: freetype/truetype: fix bounding box calculation. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 11 months ago by nigeltao

Modified:
10 years, 11 months ago

Reviewers:
bsiegert

CC:
bsiegert, golang-codereviews, remyoudompheng

Visibility:
Public.

Description

freetype/truetype: fix bounding box calculation.

Patch Set 2 : diff -r 6f1b56998c3e https://code.google.com/p/freetype-go #

Patch Set 3 : diff -r 6f1b56998c3e https://code.google.com/p/freetype-go #

Patch Set 4 : diff -r 6f1b56998c3e https://code.google.com/p/freetype-go #

Total comments: 1

Patch Set 5 : diff -r 66c7061098b5 https://code.google.com/p/freetype-go #

Created: 10 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+66 lines, -31 lines)			Patch
	M	freetype/truetype/glyph.go	View	1 2 3	7 chunks	+59 lines, -26 lines	0 comments	Download
	M	freetype/truetype/truetype_test.go	View	1	2 chunks	+7 lines, -5 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

nigeltao

Hello bsiegert@gmail.com (cc: golang-dev@googlegroups.com, remyoudompheng@gmail.com), I'd like you to review this change to https://code.google.com/p/freetype-go

10 years, 11 months ago (2013-12-19 21:45:31 UTC) #1

bsiegert

LGTM https://codereview.appspot.com/39440045/diff/60001/freetype/truetype/truetype_test.go File freetype/truetype/truetype_test.go (right): https://codereview.appspot.com/39440045/diff/60001/freetype/truetype/truetype_test.go#newcode341 freetype/truetype/truetype_test.go:341: /* TODO: check advance widths. Is that why ...

10 years, 11 months ago (2013-12-20 09:29:12 UTC) #2

nigeltao

10 years, 11 months ago (2013-12-20 23:03:15 UTC) #4

*** Submitted as
https://code.google.com/p/freetype-go/source/detail?r=39583300f291 ***

freetype/truetype: fix bounding box calculation.

R=bsiegert
CC=golang-codereviews, remyoudompheng
https://codereview.appspot.com/39440045

Expand All Messages | Collapse All Messages