code review 39200044: net: use DialTimeout in TestSelfConnect

net: use DialTimeout in TestSelfConnect

This avoids problems with systems that take a long time to
find out nothing is listening, while still testing for the
self-connect misfeature since a self-connect should be fast.
With this we may be able to remove the test for non-Linux
systems.

Tested (on GNU/Linux) by editing selfConnect in
tcpsock_posix.go to always return false and verifying that
TestSelfConnect then fails with and without this change.

Idea from Uros Bizjak.

[iant, 2013-12-27 14:52:29]

Hello golang-codereviews@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go

[bradfitz, 2013-12-27 16:33:44]

LGTM



On Fri, Dec 27, 2013 at 6:52 AM, <iant@golang.org> wrote:

> Reviewers: golang-codereviews,
>
> Message:
> Hello golang-codereviews@googlegroups.com,
>
> I'd like you to review this change to
> https://code.google.com/p/go
>
>
> Description:
> net: use DialTimeout in TestSelfConnect
>
> This avoids problems with systems that take a long time to
> find out nothing is listening, while still testing for the
> self-connect misfeature since a self-connect should be fast.
> With this we may be able to remove the test for non-Linux
> systems.
>
> Tested (on GNU/Linux) by editing selfConnect in
> tcpsock_posix.go to always return false and verifying that
> TestSelfConnect then fails with and without this change.
>
> Idea from Uros Bizjak.
>
> Please review this at https://codereview.appspot.com/39200044/
>
> Affected files (+1, -1 lines):
>   M src/pkg/net/dial_test.go
>
>
> Index: src/pkg/net/dial_test.go
> ===================================================================
> --- a/src/pkg/net/dial_test.go
> +++ b/src/pkg/net/dial_test.go
> @@ -147,7 +147,7 @@
>                 n = 100
>         }
>         for i := 0; i < n; i++ {
> -               c, err := Dial("tcp", addr)
> +               c, err := DialTimeout("tcp", addr, time.Millisecond)
>                 if err == nil {
>                         c.Close()
>                         t.Errorf("#%d: Dial %q succeeded", i, addr)
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
>

[iant, 2013-12-27 16:49:49]

*** Submitted as https://code.google.com/p/go/source/detail?r=340bbaa0e3eb ***

net: use DialTimeout in TestSelfConnect

This avoids problems with systems that take a long time to
find out nothing is listening, while still testing for the
self-connect misfeature since a self-connect should be fast.
With this we may be able to remove the test for non-Linux
systems.

Tested (on GNU/Linux) by editing selfConnect in
tcpsock_posix.go to always return false and verifying that
TestSelfConnect then fails with and without this change.

Idea from Uros Bizjak.

R=golang-codereviews, bradfitz
CC=golang-codereviews
https://codereview.appspot.com/39200044