code review 38940043: gosshnew/ssh/agent: move ssh-agent support into separat...

gosshnew/ssh/agent: move ssh-agent support into separate package.

[hanwen-google, 2013-12-08 00:41:42]

Hello agl1, dave@cheney.net, jpsugar@google.com (cc: agl@golang.org,
dave@cheney.net, golang-dev@googlegroups.com, hanwen@google.com,
jpsugar@google.com),

I'd like you to review this change to
https://hanwen%40google.com@code.google.com/p/gosshnew/

[agl1, 2013-12-09 21:12:06]

Note that this change doesn't touch agent.go nor agent_test.go. I would have
expected them to be deleted.

https://codereview.appspot.com/38940043/diff/60001/ssh/agent/agent.go
File ssh/agent/agent.go (right):

https://codereview.appspot.com/38940043/diff/60001/ssh/agent/agent.go#newcode6
ssh/agent/agent.go:6: Package agent implements a client to a ssh-agent daemon.
s/a/an/

https://codereview.appspot.com/38940043/diff/60001/ssh/agent/agent.go#newcode192
ssh/agent/agent.go:192: // List returns the identities known to the agent.
The comment suggests that the function was going to be renamed, but it hasn't
been.

https://codereview.appspot.com/38940043/diff/60001/ssh/agent/agent.go#newcode331
ssh/agent/agent.go:331: sig := Sig{}
var sig Sig

[agl1, 2013-12-09 21:12:16]

LGTM with nits mentioned.

[jpsugar, 2013-12-09 21:36:43]

https://codereview.appspot.com/38940043/diff/60001/ssh/agent/agent.go
File ssh/agent/agent.go (right):

https://codereview.appspot.com/38940043/diff/60001/ssh/agent/agent.go#newcode23
ssh/agent/agent.go:23: "code.google.com/p/gosshnew.agent/ssh"
Why is this .agent?

https://codereview.appspot.com/38940043/diff/60001/ssh/agent/agent.go#newcode331
ssh/agent/agent.go:331: sig := Sig{}
On 2013/12/09 21:12:06, agl1 wrote:
> var sig Sig

Or remove the local type:

var sig struct { ... }

[hanwen-google, 2013-12-10 09:56:09]

I assume you don't see a delete because Hg has file identity (in contrast to
Git), and I ran "hg mv"

https://codereview.appspot.com/38940043/diff/60001/ssh/agent/agent.go
File ssh/agent/agent.go (right):

https://codereview.appspot.com/38940043/diff/60001/ssh/agent/agent.go#newcode6
ssh/agent/agent.go:6: Package agent implements a client to a ssh-agent daemon.
On 2013/12/09 21:12:06, agl1 wrote:
> s/a/an/

Done.

https://codereview.appspot.com/38940043/diff/60001/ssh/agent/agent.go#newcode23
ssh/agent/agent.go:23: "code.google.com/p/gosshnew.agent/ssh"
On 2013/12/09 21:36:43, jpsugar wrote:
> Why is this .agent?

oops! side product of my juggling around 5 CLs in parallel.

https://codereview.appspot.com/38940043/diff/60001/ssh/agent/agent.go#newcode192
ssh/agent/agent.go:192: // List returns the identities known to the agent.
On 2013/12/09 21:12:06, agl1 wrote:
> The comment suggests that the function was going to be renamed, but it hasn't
> been.

Done.

https://codereview.appspot.com/38940043/diff/60001/ssh/agent/agent.go#newcode331
ssh/agent/agent.go:331: sig := Sig{}
On 2013/12/09 21:36:43, jpsugar wrote:
> On 2013/12/09 21:12:06, agl1 wrote:
> > var sig Sig
> 
> Or remove the local type:
> 
> var sig struct { ... }

Done.

[hanwen-google, 2013-12-10 09:57:12]

*** Submitted as https://code.google.com/p/gosshnew/source/detail?r=f904ff1d1391
***

gosshnew/ssh/agent: move ssh-agent support into separate package.

R=agl, dave, jpsugar
CC=agl, dave, golang-dev, hanwen, jpsugar
https://codereview.appspot.com/38940043