Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(125)

Issue 38940043: code review 38940043: gosshnew/ssh/agent: move ssh-agent support into separat... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 9 months ago by hanwen-google
Modified:
7 years, 9 months ago
Reviewers:
agl1
CC:
agl1, dfc, jpsugar, golang-dev, hanwen-google
Visibility:
Public.

Description

gosshnew/ssh/agent: move ssh-agent support into separate package.

Patch Set 1 #

Patch Set 2 : diff -r df47a60efacc https://hanwen%40google.com@code.google.com/p/gosshnew/ #

Patch Set 3 : diff -r df47a60efacc https://hanwen%40google.com@code.google.com/p/gosshnew/ #

Patch Set 4 : diff -r df47a60efacc https://hanwen%40google.com@code.google.com/p/gosshnew/ #

Total comments: 9

Patch Set 5 : diff -r bb1e8d449b04 https://hanwen%40google.com@code.google.com/p/gosshnew/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+227 lines, -116 lines) Patch
M ssh/agent/agent.go View 1 2 3 4 12 chunks +114 lines, -53 lines 0 comments Download
M ssh/agent/agent_test.go View 1 2 3 4 2 chunks +113 lines, -19 lines 0 comments Download
M ssh/client_auth.go View 1 1 chunk +0 lines, -43 lines 0 comments Download
M ssh/doc.go View 1 2 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6
hanwen-google
Hello agl1, dave@cheney.net, jpsugar@google.com (cc: agl@golang.org, dave@cheney.net, golang-dev@googlegroups.com, hanwen@google.com, jpsugar@google.com), I'd like you to review ...
7 years, 9 months ago (2013-12-08 00:41:42 UTC) #1
agl1
Note that this change doesn't touch agent.go nor agent_test.go. I would have expected them to ...
7 years, 9 months ago (2013-12-09 21:12:06 UTC) #2
agl1
LGTM with nits mentioned.
7 years, 9 months ago (2013-12-09 21:12:16 UTC) #3
jpsugar
https://codereview.appspot.com/38940043/diff/60001/ssh/agent/agent.go File ssh/agent/agent.go (right): https://codereview.appspot.com/38940043/diff/60001/ssh/agent/agent.go#newcode23 ssh/agent/agent.go:23: "code.google.com/p/gosshnew.agent/ssh" Why is this .agent? https://codereview.appspot.com/38940043/diff/60001/ssh/agent/agent.go#newcode331 ssh/agent/agent.go:331: sig := ...
7 years, 9 months ago (2013-12-09 21:36:43 UTC) #4
hanwen-google
I assume you don't see a delete because Hg has file identity (in contrast to ...
7 years, 9 months ago (2013-12-10 09:56:09 UTC) #5
hanwen-google
7 years, 9 months ago (2013-12-10 09:57:12 UTC) #6
*** Submitted as https://code.google.com/p/gosshnew/source/detail?r=f904ff1d1391
***

gosshnew/ssh/agent: move ssh-agent support into separate package.

R=agl, dave, jpsugar
CC=agl, dave, golang-dev, hanwen, jpsugar
https://codereview.appspot.com/38940043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b