code review 38720044: go.tools/dashboard/builder: do not fatal on subrepo fet...

go.tools/dashboard/builder: do not fatal on subrepo fetch errors

When fetching repos it is not uncommon for a 500 or 503 to be returned
from code.google.com. When this happens, log the error and continue so
that we try again later, rather than treating this as fatal.

[jsing, 2013-12-10 13:21:31]

Hello adg@golang.org (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go.tools

[dvyukov, 2013-12-10 13:32:22]

I would add some backoff, because it's usually either rate limiting or the repo
is down.

[jsing, 2013-12-10 14:29:33]

On 2013/12/10 13:32:22, dvyukov wrote:
> I would add some backoff, because it's usually either rate limiting or the
repo
> is down.

We already sleep once we've tried all of the subrepos, so I'm not sure that we
gain much by adding an additional backoff and/or retries. In most cases it seems
that we fail the occasional subrepo case, then sleep and pick it up next time
around. If we wanted to implement backoff then it would probably make sense to
do it for the existing sleep case.

[adg, 2013-12-11 02:38:34]

LGTM

I'm happy with the simple approach.

[jsing, 2013-12-11 12:47:46]

*** Submitted as
https://code.google.com/p/go/source/detail?r=efda98edbd15&repo=tools ***

go.tools/dashboard/builder: do not fatal on subrepo fetch errors

When fetching repos it is not uncommon for a 500 or 503 to be returned
from code.google.com. When this happens, log the error and continue so
that we try again later, rather than treating this as fatal.

R=adg, dvyukov
CC=golang-dev
https://codereview.appspot.com/38720044