Issue 38540044: unify rpc.IsNoSuchRequest and NoImplementedErr

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 38540044: unify rpc.IsNoSuchRequest and NoImplementedErr (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 4 months ago by dimitern

Modified:
10 years, 4 months ago

Reviewers:
mp+199336, rog

Visibility:
Public.

Description

unify rpc.IsNoSuchRequest and NoImplementedErr Introducing CodeNotImplemented in params and rpc. Now both rpc.NoSuchRequest and api.NotImplementedError are serialized and handled as an error, satisfying params.IsCodeNotImplemented(), so it can be checked only once. Kept "no such request " prefix of the error message for compatibility. https://code.launchpad.net/~dimitern/juju-core/225-unify-not-implemented-errors/+merge/199336 Requires: https://code.launchpad.net/~dimitern/juju-core/225-upload-charm-via-api/+merge/199251 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : unify rpc.IsNoSuchRequest and NoImplementedErr #

Total comments: 2

Patch Set 3 : unify rpc.IsNoSuchRequest and NoImplementedErr #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+93 lines, -64 lines)			Patch
A	[revision details]	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	cmd/juju/addmachine.go	View		2 chunks	+1 line, -2 lines	0 comments	Download
M	cmd/juju/constraints.go	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	cmd/juju/debughooks.go	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	cmd/juju/destroymachine.go	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	cmd/juju/environment.go	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	cmd/juju/set.go	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	cmd/juju/ssh.go	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	cmd/juju/unset.go	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	cmd/juju/upgradejuju.go	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	rpc/client.go	View		2 chunks	+4 lines, -7 lines	0 comments	Download
M	rpc/reflect_test.go	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download
M	rpc/rpc_test.go	View	1	5 chunks	+14 lines, -4 lines	0 comments	Download
M	rpc/rpcreflect/value.go	View	1	2 chunks	+21 lines, -2 lines	0 comments	Download
M	rpc/server.go	View	1	3 chunks	+18 lines, -0 lines	0 comments	Download
M	state/api/client.go	View	1 2	2 chunks	+5 lines, -27 lines	0 comments	Download
M	state/api/client_test.go	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	state/api/params/apierror.go	View		2 chunks	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rog

LGTM modulo the below. Thanks! https://codereview.appspot.com/38540044/diff/20001/state/api/client.go File state/api/client.go (right): https://codereview.appspot.com/38540044/diff/20001/state/api/client.go#newcode362 state/api/client.go:362: type NotImplementedError struct { ...

10 years, 4 months ago (2013-12-18 09:10:03 UTC) #2

dimitern

10 years, 4 months ago (2013-12-18 09:24:59 UTC) #3

Please take a look.

https://codereview.appspot.com/38540044/diff/20001/state/api/client.go
File state/api/client.go (right):

https://codereview.appspot.com/38540044/diff/20001/state/api/client.go#newcod...
state/api/client.go:362: type NotImplementedError struct {
On 2013/12/18 09:10:03, rog wrote:
> I don't think we need this type.
> &params.Error{
>    Message: "charm upload is not supported by the API server",
>    Code: params.CodeNotimplemented,
> }
> 
> should be sufficient I think.

Done.

Expand All Messages | Collapse All Messages