Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(381)

Issue 3838042: Tie break-visibility of OctavateEight to the one of the associated clef (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 6 months ago by Reinhold
Modified:
8 years, 5 months ago
Reviewers:
Neil Puttock
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Tie break-visibility of OctavateEight to the one of the associated clef It does not make sense to handle break-visibility of OctavateEight grobs independently from the clef they are assigned to. This patch lets OctavateEight always inherit break-visibility from the Clef grob and ignores any break-visibility assigned to OctavateEight.

Patch Set 1 #

Patch Set 2 : use a callback instead of explicitly assigning the clef's break-visibility #

Patch Set 3 : Use Scheme instead of C++ to define a more general callback that can be used for other grobs, too #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -11 lines) Patch
M Documentation/notation/changing-defaults.itely View 1 1 chunk +4 lines, -5 lines 0 comments Download
A input/regression/clef-oct-visibility.ly View 1 1 chunk +28 lines, -0 lines 0 comments Download
M lily/clef-engraver.cc View 1 1 chunk +1 line, -5 lines 0 comments Download
M scm/define-grobs.scm View 1 2 1 chunk +1 line, -1 line 0 comments Download
M scm/output-lib.scm View 1 2 1 chunk +4 lines, -0 lines 1 comment Download

Messages

Total messages: 7
Neil Puttock
Hi Reinhold, I'd prefer a callback to copy the Clef's setting, then it's documented automatically ...
8 years, 6 months ago (2010-12-28 22:06:43 UTC) #1
Reinhold
On 2010/12/28 22:06:43, Neil Puttock wrote: > I'd prefer a callback to copy the Clef's ...
8 years, 6 months ago (2010-12-28 23:02:25 UTC) #2
Reinhold
Okay, new patch uploaded, which uses a callback to inherit the OctavateEight's break-visibility from the ...
8 years, 6 months ago (2010-12-28 23:43:46 UTC) #3
Neil Puttock
On 2010/12/28 23:02:25, Reinhold wrote: > Hmm, I can't really think of a situation where ...
8 years, 6 months ago (2010-12-29 00:00:37 UTC) #4
Neil Puttock
On 2010/12/28 23:43:46, Reinhold wrote: > Okay, new patch uploaded, which uses a callback to ...
8 years, 6 months ago (2010-12-29 00:01:45 UTC) #5
Reinhold
On 2010/12/29 00:01:45, Neil Puttock wrote: > Looks OK, though it would be simpler to ...
8 years, 6 months ago (2010-12-29 00:09:04 UTC) #6
Neil Puttock
8 years, 6 months ago (2010-12-29 00:55:06 UTC) #7
LGTM.

http://codereview.appspot.com/3838042/diff/2002/scm/output-lib.scm
File scm/output-lib.scm (right):

http://codereview.appspot.com/3838042/diff/2002/scm/output-lib.scm#newcode238
scm/output-lib.scm:238: (let ((parent (ly:grob-parent grob 0)))
(ly:grob-parent grob X)
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b