Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1398)

Issue 3832042: Adding tests + fixes + classpath change(to avoid gwt+gae gwttestcase bug) (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 4 months ago by gal.dolber
Modified:
13 years, 4 months ago
Reviewers:
higayasuo
Base URL:
http://slim3.googlecode.com/svn/trunk/slim3/
Visibility:
Public.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+465 lines, -26 lines) Patch
M . View 0 chunks +-1 lines, --1 lines 0 comments Download
M .classpath View 1 chunk +12 lines, -12 lines 0 comments Download
M build.xml View 1 chunk +1 line, -0 lines 0 comments Download
M src/main/java/org/slim3/datastore/AbstractQuery.java View 3 chunks +35 lines, -12 lines 0 comments Download
M src/main/resources/org/slim3/gwt/emul/com/google/appengine/api/datastore/Key.java View 3 chunks +36 lines, -3 lines 0 comments Download
A src/main/resources/org/slim3/gwt/emul/com/google/appengine/api/datastore/KeyFactory.java View 1 chunk +105 lines, -0 lines 0 comments Download
A src/test/java/com/google/appengine/api/datastore/Datastore.gwt.xml View 1 chunk +7 lines, -0 lines 0 comments Download
A src/test/java/com/google/appengine/api/datastore/KeyFactoryTest.java View 1 chunk +126 lines, -0 lines 0 comments Download
A src/test/java/com/google/appengine/api/datastore/KeyTest.java View 1 chunk +144 lines, -0 lines 0 comments Download

Messages

Total messages: 4
gal.dolber
13 years, 4 months ago (2010-12-23 03:41:41 UTC) #1
gal.dolber
(I tried to update the previous review, need to learn how to do that :) ...
13 years, 4 months ago (2010-12-23 03:43:18 UTC) #2
higayasuo
On 2010/12/23 03:43:18, gal.dolber wrote: > (I tried to update the previous review, need to ...
13 years, 4 months ago (2010-12-23 04:16:10 UTC) #3
gal.dolber
13 years, 4 months ago (2010-12-23 04:23:10 UTC) #4
Thanks! committing!

On Thu, Dec 23, 2010 at 12:16 AM, <higayasuo@gmail.com> wrote:

> On 2010/12/23 03:43:18, gal.dolber wrote:
>
>> (I tried to update the previous review, need to learn how to do that
>>
> :) )
>
>> On 2010/12/23 03:41:41, gal.dolber wrote:
>>
>
> GJ!!!
> I thought the test was enough to use browser directly.
> Your tests are better than what I thought.
>
>
> http://codereview.appspot.com/3832042/
>



-- 
Guit: Elegant, beautiful, modular and *production ready* gwt applications.

http://code.google.com/p/guit/
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b