Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(7668)

Issue 3826043: Review: make flags: USE_FIELD3D, USE_JASPER (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 3 months ago by larrygritz
Modified:
13 years, 3 months ago
Reviewers:
Chris Foster, oiio-dev
Base URL:
http://svn.openimageio.org/oiio/trunk/
Visibility:
Public.

Description

Make it easy to avoid compiling with field3d or Jasper, even if they are found on your build system (e.g., if you don't need them and can't rely on their being present on your deployment machines).

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -16 lines) Patch
Makefile View 2 chunks +17 lines, -6 lines 0 comments Download
src/CMakeLists.txt View 1 chunk +1 line, -0 lines 0 comments Download
src/field3d.imageio/CMakeLists.txt View 1 chunk +4 lines, -2 lines 1 comment Download
src/jpeg2000.imageio/CMakeLists.txt View 1 chunk +4 lines, -2 lines 0 comments Download
src/libOpenImageIO/CMakeLists.txt View 1 chunk +6 lines, -6 lines 1 comment Download

Messages

Total messages: 2
larrygritz
13 years, 3 months ago (2011-01-03 17:38:50 UTC) #1
Chris Foster
13 years, 3 months ago (2011-01-08 04:23:27 UTC) #2
LGTM, with some minor comments -

http://codereview.appspot.com/3826043/diff/1/src/field3d.imageio/CMakeLists.txt
File src/field3d.imageio/CMakeLists.txt (right):

http://codereview.appspot.com/3826043/diff/1/src/field3d.imageio/CMakeLists.t...
src/field3d.imageio/CMakeLists.txt:7: message (STATUS "Field3D not found:
field3d plugin will not be built")
It's a small thing, but this status message isn't technically correct if the
user has set USE_FIELD3D=FALSE, it could potentially be confusing.

http://codereview.appspot.com/3826043/diff/1/src/libOpenImageIO/CMakeLists.txt
File src/libOpenImageIO/CMakeLists.txt (left):

http://codereview.appspot.com/3826043/diff/1/src/libOpenImageIO/CMakeLists.tx...
src/libOpenImageIO/CMakeLists.txt:132: message (STATUS "Jasper not found:
jpeg2000 plugin will not be built")
This status message is redundant now given the new one in
jasper.imageio/CmakeLists.txt.  Same for the Field3D message below.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b