Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(6)

Issue 3810041: Output es53 frame api (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 6 months ago by Jasvir
Modified:
15 years, 5 months ago
Reviewers:
ihab.awad, metaweta
CC:
google-caja-discuss_googlegroups.com
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Description

* Constructs a js file that can be used to document.write into iframes

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+155 lines, -10 lines) Patch
M build.xml View 3 chunks +19 lines, -0 lines 0 comments Download
M src/com/google/caja/ancillary/jsdoc/JsdocMain.java View 2 chunks +2 lines, -1 line 1 comment Download
M src/com/google/caja/ancillary/linter/Linter.java View 2 chunks +2 lines, -2 lines 1 comment Download
M src/com/google/caja/lang/css/CssPropertyPatterns.java View 1 chunk +1 line, -1 line 1 comment Download
M src/com/google/caja/lang/html/HtmlDefinitions.java View 1 chunk +1 line, -1 line 1 comment Download
M src/com/google/caja/plugin/PluginMessageType.java View 1 chunk +1 line, -1 line 0 comments Download
A src/com/google/caja/plugin/prepare-modules.js View 1 chunk +26 lines, -0 lines 0 comments Download
M src/com/google/caja/tools/BuildCommand.java View 1 chunk +3 lines, -2 lines 0 comments Download
M src/com/google/caja/tools/EnumsToJs.java View 2 chunks +2 lines, -1 line 0 comments Download
M src/com/google/caja/tools/GenRuleAntTask.java View 1 chunk +1 line, -1 line 0 comments Download
A src/com/google/caja/tools/JsToVar.java View 1 chunk +97 lines, -0 lines 0 comments Download

Messages

Total messages: 4
Jasvir
15 years, 6 months ago (2010-12-20 21:21:42 UTC) #1
metaweta
LGTM
15 years, 6 months ago (2010-12-23 23:00:01 UTC) #2
metaweta
http://codereview.appspot.com/3810041/diff/1/src/com/google/caja/ancillary/jsdoc/JsdocMain.java File src/com/google/caja/ancillary/jsdoc/JsdocMain.java (right): http://codereview.appspot.com/3810041/diff/1/src/com/google/caja/ancillary/jsdoc/JsdocMain.java#newcode126 src/com/google/caja/ancillary/jsdoc/JsdocMain.java:126: public boolean build(List<File> inputs, List<File> deps, Map<String, Object> options, ...
15 years, 5 months ago (2011-01-12 17:15:56 UTC) #3
Jasvir
15 years, 5 months ago (2011-01-13 00:42:58 UTC) #4
Fixed and submitted @4343
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b