Issue 3797043: Show OOM notification bar and crash render process immediately in case of OOM in v8

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3797043: Show OOM notification bar and crash render process immediately in case of OOM in v8

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 4 months ago by Yury Semikhatsky

Modified:
13 years, 4 months ago

Reviewers:
darin, antonm, Dimitri Glazkov, ager

CC:
chromium-reviews_chromium.org

Base URL:
http://svn.webkit.org/repository/webkit/trunk

Visibility:
Public.

Description

Show OOM notification bar and crash render process immediately in case of OOM in v8. This is WebKit's part of the change. Chromium's part is http://codereview.chromium.org/6006006/ BUG=40521 TEST=

Patch Set 2 : style #

Total comments: 4

Created: 13 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+10 lines, -13 lines)			Patch
M	WebCore/bindings/v8/V8DOMWindowShell.cpp	View	2 chunks	+4 lines, -3 lines	2 comments	Download
M	WebCore/bindings/v8/V8Proxy.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	WebCore/platform/chromium/ChromiumBridge.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	WebKit/chromium/public/WebKitClient.h	View	1 chunk	+2 lines, -0 lines	2 comments	Download
M	WebKit/chromium/src/ChromiumBridge.cpp	View	1 chunk	+2 lines, -8 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

antonm

LGTM http://codereview.appspot.com/3797043/diff/2001/WebCore/bindings/v8/V8DOMWindowShell.cpp File WebCore/bindings/v8/V8DOMWindowShell.cpp (right): http://codereview.appspot.com/3797043/diff/2001/WebCore/bindings/v8/V8DOMWindowShell.cpp#newcode260 WebCore/bindings/v8/V8DOMWindowShell.cpp:260: // Binding code will handle OOM exceptions. nit: ...

13 years, 4 months ago (2010-12-23 16:29:56 UTC) #2

antonm

13 years, 4 months ago (2010-12-29 11:21:26 UTC) #3

http://codereview.appspot.com/3797043/diff/2001/WebCore/bindings/v8/V8DOMWind...
File WebCore/bindings/v8/V8DOMWindowShell.cpp (right):

http://codereview.appspot.com/3797043/diff/2001/WebCore/bindings/v8/V8DOMWind...
WebCore/bindings/v8/V8DOMWindowShell.cpp:78:
PlatformBridge::notifyJSOutOfMemory();
afterthought: technically handleFatalErrorInV8 can be invoked in different cases
(e.g. if one forgot to create handle scope and attempts to allocate new local
handle).

Expand All Messages | Collapse All Messages