Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(684)

Issue 37970043: code review 37970043: go.tools/ssa: move AllFunctions to ssautil subpackage (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years ago by adonovan
Modified:
8 years ago
Reviewers:
gri
CC:
gri, golang-dev
Visibility:
Public.

Description

go.tools/ssa: move AllFunctions to ssautil subpackage

Patch Set 1 #

Patch Set 2 : diff -r b522e6a8d9b8 https://code.google.com/p/go.tools #

Patch Set 3 : diff -r b522e6a8d9b8 https://code.google.com/p/go.tools #

Patch Set 4 : diff -r b522e6a8d9b8 https://code.google.com/p/go.tools #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -16 lines) Patch
M oracle/peers.go View 1 2 chunks +2 lines, -1 line 0 comments Download
M ssa/doc.go View 1 1 chunk +3 lines, -5 lines 0 comments Download
M ssa/ssautil/visit.go View 1 3 chunks +11 lines, -9 lines 0 comments Download
M ssa/stdlib_test.go View 1 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 3
adonovan
Hello gri@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.tools
8 years ago (2013-12-05 22:06:35 UTC) #1
gri
LGTM
8 years ago (2013-12-05 22:15:11 UTC) #2
adonovan
8 years ago (2013-12-05 22:16:02 UTC) #3
*** Submitted as
https://code.google.com/p/go/source/detail?r=fa2302314916&repo=tools ***

go.tools/ssa: move AllFunctions to ssautil subpackage

R=gri
CC=golang-dev
https://codereview.appspot.com/37970043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b