Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(204)

Issue 3782042: Doc: NR cross-staff (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 6 months ago by Carl
Modified:
8 years, 5 months ago
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Doc: NR cross-staff Some collisions are allowed by design, as controlled by the 'cross-staff' property.

Patch Set 1 #

Total comments: 13

Patch Set 2 : Revised in compliance with comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -0 lines) Patch
M Documentation/notation/keyboards.itely View 1 1 chunk +33 lines, -0 lines 0 comments Download

Messages

Total messages: 14
Carl
Here's Keith's patch for cross-staff documentation. LGTM.
8 years, 6 months ago (2010-12-20 05:57:37 UTC) #1
Carl
This has been up for nearly three days now. Any comments?
8 years, 6 months ago (2010-12-23 02:19:05 UTC) #2
Valentin Villenave
LGTM. I was a bit shocked when I saw the collisions in the example, but ...
8 years, 6 months ago (2010-12-23 07:57:58 UTC) #3
pkx166h
Just one comment. http://codereview.appspot.com/3782042/diff/1/Documentation/notation/keyboards.itely File Documentation/notation/keyboards.itely (right): http://codereview.appspot.com/3782042/diff/1/Documentation/notation/keyboards.itely#newcode206 Documentation/notation/keyboards.itely:206: and other spanners that connect notes ...
8 years, 6 months ago (2010-12-23 13:14:22 UTC) #4
Keith
On 2010/12/23 07:57:58, Valentin Villenave wrote: > Oh I see: it's not a bug, it's ...
8 years, 6 months ago (2010-12-23 21:17:02 UTC) #5
Trevor Daniels
The content looks fine, but it should be rearranged a little to match the existing ...
8 years, 6 months ago (2010-12-24 08:54:38 UTC) #6
Keith
On Fri, 24 Dec 2010 00:54:38 -0800, <tdanielsmusic@googlemail.com> wrote: > [...]I would prefer to see ...
8 years, 6 months ago (2010-12-25 04:37:52 UTC) #7
Keith
See the corresponding thread on lilypond-devel for new patch. http://codereview.appspot.com/3782042/diff/1/Documentation/notation/keyboards.itely File Documentation/notation/keyboards.itely (right): http://codereview.appspot.com/3782042/diff/1/Documentation/notation/keyboards.itely#newcode195 Documentation/notation/keyboards.itely:195: ...
8 years, 6 months ago (2010-12-25 04:43:13 UTC) #8
c_sorensen
On 12/24/10 9:37 PM, "Keith OHara" <k-ohara5a5a@oco.net> wrote: > On Fri, 24 Dec 2010 00:54:38 ...
8 years, 6 months ago (2010-12-25 05:03:14 UTC) #9
c_sorensen
On 12/24/10 9:37 PM, "Keith OHara" <k-ohara5a5a@oco.net> wrote: > On Fri, 24 Dec 2010 00:54:38 ...
8 years, 6 months ago (2010-12-25 05:26:49 UTC) #10
Carl
OK -- changes posted. Keith, The patch wouldn't apply to the previous commit (I think ...
8 years, 6 months ago (2010-12-25 05:32:54 UTC) #11
Keith
On 2010/12/25 05:32:54, Carl wrote: > Keith, > The patch wouldn't apply to the previous ...
8 years, 6 months ago (2010-12-25 05:50:31 UTC) #12
Trevor Daniels
LGTM I like this example of collisions better than the earlier one. If there are ...
8 years, 6 months ago (2010-12-25 09:07:56 UTC) #13
t.daniels_treda.co.uk
8 years, 5 months ago (2010-12-29 11:36:34 UTC) #14
tdanielsmusic@googlemail.com wrote Saturday, December 25, 2010 9:07 
AM

> If there are no averse comments over Christmas I'll push this next 
> week.

Now pushed.  Thanks again Keith.

http://codereview.appspot.com/3782042/

Trevor



Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b