Review: dump gtest and boost::test

I've been plagued for some time by seg faults in some of the unit tests (only some tests, only some platforms).  Frankly, I'm not sure if we're using the boost::test framework incorrectly, or if it's just inherently buggy, and at this point I don't care.  We use so very little of the boost test functionality, I decided to see how hard it would be to just roll my own macros, just "good enough" for our unit tests.  Works fine, no loss in functionality, no crashes, and I'm relieved to be able to dump both the boost::test and google test dependencies.

Objections?

[nemec_google.com, 2011-01-04 23:14:51]

I totally understand where you're coming from - no objections from me.

The one feature I'd think about adding is the ability to auto-add tests
instead of needing to remember to add them to main.

[malcolmhumphreys_mac.com, 2011-01-07 09:15:14]

LGTM, this fixed some segfaults I was getting in the unit tests on osx.

.malcolm

On 02/01/2011, at 4:59 PM, larrygritz@gmail.com wrote:

> Reviewers: oiio-dev_openimageio.org,
> 
> Description:
> I've been plagued for some time by seg faults in some of the unit tests
> (only some tests, only some platforms).  Frankly, I'm not sure if we're
> using the boost::test framework incorrectly, or if it's just inherently
> buggy, and at this point I don't care.  We use so very little of the
> boost test functionality, I decided to see how hard it would be to just
> roll my own macros, just "good enough" for our unit tests.  Works fine,
> no loss in functionality, no crashes, and I'm relieved to be able to
> dump both the boost::test and google test dependencies.
> 
> Objections?
> 
> 
> 
> 
> Please review this at http://codereview.appspot.com/3751042/
> 
> Affected files:
>  src/cmake/externalpackages.cmake
>  src/include/unittest.h
>  src/libOpenImageIO/CMakeLists.txt
>  src/libOpenImageIO/atomic_test.cpp
>  src/libOpenImageIO/imagebufalgo_test.cpp
>  src/libOpenImageIO/imagespec_test.cpp
>  src/libOpenImageIO/spinlock_test.cpp
>  src/libOpenImageIO/strutil_test.cpp
>  src/libOpenImageIO/ustring_test.cpp
> 
> 
> _______________________________________________
> Oiio-dev mailing list
> Oiio-dev@lists.openimageio.org
> http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org