Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1616)

Issue 3732046: Documentation of Dynamics context and postfix dynamics changes (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 6 months ago by Carl
Modified:
8 years, 6 months ago
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Documentation of Dynamics context and postfix dynamics changes

Patch Set 1 #

Total comments: 18
Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -80 lines) Patch
M Documentation/notation/expressive.itely View 3 chunks +67 lines, -62 lines 17 comments Download
M Documentation/notation/keyboards.itely View 3 chunks +7 lines, -15 lines 0 comments Download
M Documentation/notation/text.itely View 1 chunk +0 lines, -3 lines 1 comment Download

Messages

Total messages: 11
Carl
Here are Keith's suggested doc changes for the Dynamics context and postfix (de)crescendo notation.
8 years, 6 months ago (2010-12-20 05:54:05 UTC) #1
Carl
Looks mostly good to me -- one styling nit. Thanks! Carl http://codereview.appspot.com/3732046/diff/1/Documentation/notation/expressive.itely File Documentation/notation/expressive.itely (right): ...
8 years, 6 months ago (2010-12-20 05:59:45 UTC) #2
Keith
Tell me if it is trivial to load patches from lily-git onto Reitveld. The Contributors ...
8 years, 6 months ago (2010-12-20 06:44:18 UTC) #3
Trevor Daniels
Keith Some of your new material is not in the agreed style the NR, in ...
8 years, 6 months ago (2010-12-20 10:57:44 UTC) #4
Trevor Daniels
Missed this earlier http://codereview.appspot.com/3732046/diff/1/Documentation/notation/expressive.itely File Documentation/notation/expressive.itely (right): http://codereview.appspot.com/3732046/diff/1/Documentation/notation/expressive.itely#newcode390 Documentation/notation/expressive.itely:390: in @rlearning{Moving-objects}. Broken ref
8 years, 6 months ago (2010-12-20 12:54:37 UTC) #5
Carl
On 2010/12/20 06:44:18, Keith wrote: > Tell me if it is trivial to load patches ...
8 years, 6 months ago (2010-12-20 15:20:05 UTC) #6
Carl
http://codereview.appspot.com/3732046/diff/1/Documentation/notation/expressive.itely File Documentation/notation/expressive.itely (right): http://codereview.appspot.com/3732046/diff/1/Documentation/notation/expressive.itely#newcode313 Documentation/notation/expressive.itely:313: \bar "||" e2\p\< f | e2\> d\! | a2\< ...
8 years, 6 months ago (2010-12-20 15:22:30 UTC) #7
Graham Percival
On Mon, Dec 20, 2010 at 06:44:18AM +0000, k-ohara5a5a@oco.net wrote: > Tell me if it ...
8 years, 6 months ago (2010-12-20 18:41:29 UTC) #8
Graham Percival (old account)
Quite nice for an initial patch. For future reference, I would recommend working on slightly ...
8 years, 6 months ago (2010-12-20 18:53:19 UTC) #9
Keith
The patch looks bigger than it is, due to my moving a block. I explain ...
8 years, 6 months ago (2010-12-21 01:37:02 UTC) #10
Keith
8 years, 6 months ago (2010-12-22 04:15:26 UTC) #11
I posted a revised patch under my own login, directly from the system that
compiled it,at
http://codereview.appspot.com/3743045/

Carl, the C G was clear enough that I had no trouble going straight to Rietveld,
but I can send (or you can grab) the revised patch to post under this issue# if
you prefer.

The revision changes less than this one did, but it gets the job done and
complies, I'm pretty sure, with doc style.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b