Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(214)

Issue 37270043: code review 37270043: go.tools/ssa: eliminate remaining uses of operands of "... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years ago by adonovan
Modified:
8 years ago
Reviewers:
gri
CC:
gri, golang-dev
Visibility:
Public.

Description

go.tools/ssa: eliminate remaining uses of operands of "untyped" type. Added sanity check.

Patch Set 1 #

Patch Set 2 : diff -r 25d507bc74cb https://code.google.com/p/go.tools #

Patch Set 3 : diff -r 25d507bc74cb https://code.google.com/p/go.tools #

Patch Set 4 : diff -r 25d507bc74cb https://code.google.com/p/go.tools #

Patch Set 5 : diff -r 25d507bc74cb https://code.google.com/p/go.tools #

Patch Set 6 : diff -r a44dba07e828 https://code.google.com/p/go.tools #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -9 lines) Patch
M ssa/builder.go View 1 2 3 4 3 chunks +6 lines, -6 lines 0 comments Download
M ssa/const.go View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
M ssa/example_test.go View 1 1 chunk +1 line, -1 line 0 comments Download
M ssa/sanity.go View 1 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 3
adonovan
Hello gri@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.tools
8 years ago (2013-12-04 18:39:30 UTC) #1
gri
LGTM
8 years ago (2013-12-04 18:43:00 UTC) #2
adonovan
8 years ago (2013-12-04 18:59:56 UTC) #3
*** Submitted as
https://code.google.com/p/go/source/detail?r=55504f60f053&repo=tools ***

go.tools/ssa: eliminate remaining uses of operands of "untyped" type.

Added sanity check.

R=gri
CC=golang-dev
https://codereview.appspot.com/37270043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b