Issue 37240043: Fix GUI connection problems

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 37240043: Fix GUI connection problems

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 5 months ago by gary.poster

Modified:
10 years, 5 months ago

Reviewers:
mp+197757, frankban

Visibility:
Public.

Description

Fix GUI connection problems This fixes two problems. One was introduced by the authtoken work: if you deployed a bundle, then quickstart could no longer launch a browser. The other was pre-existing, I believe, but related: if it took too long to connect to the GUI server, then quickstart would fall over. To QA, I suggest simply trying to run `.venv/bin/python juju-quickstart bundle:~jorge/jenkins/5/jenkins-scalable` or similar, and verify that the browser opens as expected. To also test authtoken, you could instead run `.venv/bin/python juju-quickstart --gui-charm-url cs:~juju-gui/precise/juju-gui-136 bundle:~jorge/jenkins/5/jenkins-scalable`. The second spelling should log you in automatically. Thank you! https://code.launchpad.net/~gary/juju-quickstart/fixsocketbugs/+merge/197757 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix GUI connection problems #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+54 lines, -14 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	quickstart/app.py	View	2 chunks	+15 lines, -6 lines	0 comments	Download
M	quickstart/manage.py	View	2 chunks	+3 lines, -0 lines	0 comments	Download
M	quickstart/tests/test_app.py	View	2 chunks	+32 lines, -8 lines	0 comments	Download
M	quickstart/tests/test_manage.py	View	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

frankban

Code LGTM, QA ok (on local and ec2) and very nice tests. Thank you! PS: ...

10 years, 5 months ago (2013-12-04 17:41:25 UTC) #2

gary.poster

10 years, 5 months ago (2013-12-04 17:46:17 UTC) #3

*** Submitted:

Fix GUI connection problems

This fixes two problems.  One was introduced by the authtoken work: if you
deployed a bundle, then quickstart could no longer launch a browser.  The other
was pre-existing, I believe, but related: if it took too long to connect to the
GUI server, then quickstart would fall over.

To QA, I suggest simply trying to run `.venv/bin/python juju-quickstart
bundle:~jorge/jenkins/5/jenkins-scalable` or similar, and verify that the
browser opens as expected.  To also test authtoken, you could instead run
`.venv/bin/python juju-quickstart --gui-charm-url
cs:~juju-gui/precise/juju-gui-136 bundle:~jorge/jenkins/5/jenkins-scalable`. 
The second spelling should log you in automatically.

Thank you!

R=frankban
CC=
https://codereview.appspot.com/37240043

Expand All Messages | Collapse All Messages