Issue 37150044: code review 37150044: crypto/sha512: block implementation in amd64 assembly

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 37150044: code review 37150044: crypto/sha512: block implementation in amd64 assembly (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 6 months ago by jsing

Modified:
11 years, 6 months ago

Reviewers:
agl1

CC:
agl1, golang-codereviews

Visibility:
Public.

Description

crypto/sha512: block implementation in amd64 assembly Benchmark on Intel(R) Xeon(R) CPU X5650 @ 2.67GHz benchmark old ns/op new ns/op delta BenchmarkHash8Bytes 1779 1114 -37.38% BenchmarkHash1K 9848 4894 -50.30% BenchmarkHash8K 68513 32187 -53.02% benchmark old MB/s new MB/s speedup BenchmarkHash8Bytes 4.50 7.18 1.60x BenchmarkHash1K 103.97 209.19 2.01x BenchmarkHash8K 119.57 254.51 2.13x

Patch Set 1 : diff -r c4b7c0824984 https://go.googlecode.com/hg/ #

Patch Set 2 : diff -r 1b7c5daffdff https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 1b7c5daffdff https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r eee24823915d https://go.googlecode.com/hg/ #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+192 lines, -173 lines)			Patch
M	src/pkg/crypto/sha512/sha512block.go	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/pkg/crypto/sha512/sha512block_amd64.s	View		3 chunks	+189 lines, -172 lines	0 comments	Download
M	src/pkg/crypto/sha512/sha512block_decl.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

jsing

Hello agl@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

11 years, 6 months ago (2013-12-22 06:48:29 UTC) #1

agl1

LGTM. This is using a lot of stack space, but it's faster than what we ...

11 years, 6 months ago (2014-01-06 18:36:30 UTC) #2

jsing

On 2014/01/06 18:36:30, agl1 wrote: > LGTM. > > This is using a lot of ...

11 years, 6 months ago (2014-01-06 23:22:48 UTC) #4

jsing

11 years, 6 months ago (2014-01-07 12:16:55 UTC) #5

*** Submitted as https://code.google.com/p/go/source/detail?r=8168500850d9 ***

crypto/sha512: block implementation in amd64 assembly

Benchmark on Intel(R) Xeon(R) CPU X5650  @ 2.67GHz

benchmark              old ns/op    new ns/op    delta
BenchmarkHash8Bytes         1779         1114  -37.38%
BenchmarkHash1K             9848         4894  -50.30%
BenchmarkHash8K            68513        32187  -53.02%

benchmark               old MB/s     new MB/s  speedup
BenchmarkHash8Bytes         4.50         7.18    1.60x
BenchmarkHash1K           103.97       209.19    2.01x
BenchmarkHash8K           119.57       254.51    2.13x

R=agl
CC=golang-codereviews
https://codereview.appspot.com/37150044

Expand All Messages | Collapse All Messages