Issue 37150043: Envs management: code reorganization.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 37150043: Envs management: code reorganization.

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 5 months ago by frankban

Modified:
10 years, 5 months ago

Reviewers:
mp+197709, gary.poster

Visibility:
Public.

Description

Envs management: code reorganization. This branch includes code reorg as a preparation for the upcoming envs management work. It's just about mechanically moving code to the new models package, except for a minor fix to test_init_environment in test_manage.py. https://code.launchpad.net/~frankban/juju-quickstart/env-management-1/+merge/197709 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Envs management: code reorganization. #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+269 lines, -202 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	quickstart/manage.py	View	3 chunks	+6 lines, -3 lines	0 comments	Download
A	quickstart/models/__init__.py	View	1 chunk	+17 lines, -0 lines	0 comments	Download
M	quickstart/models/charms.py	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A	quickstart/models/envs.py	View	1 chunk	+104 lines, -0 lines	0 comments	Download
A	quickstart/tests/models/__init__.py	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	quickstart/tests/models/test_charms.py	View	1 chunk	+1 line, -1 line	0 comments	Download
A	quickstart/tests/models/test_envs.py	View	1 chunk	+136 lines, -0 lines	0 comments	Download
M	quickstart/tests/test_manage.py	View	2 chunks	+3 lines, -4 lines	0 comments	Download
M	quickstart/tests/test_utils.py	View	2 chunks	+0 lines, -111 lines	0 comments	Download
M	quickstart/utils.py	View	3 chunks	+2 lines, -85 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

frankban

10 years, 5 months ago (2013-12-04 13:29:45 UTC) #3

*** Submitted:

Envs management: code reorganization.

This branch includes code reorg as
a preparation for the upcoming envs
management work.

It's just about mechanically moving code 
to the new models package, except for a 
minor fix to test_init_environment in 
test_manage.py.

R=gary.poster
CC=
https://codereview.appspot.com/37150043

Expand All Messages | Collapse All Messages