Issue 369960043: fix the daisy_chain_wrapper when file is bigger than _DEFAULT_DOWNLOAD_CHUNK_SIZE

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 369960043: fix the daisy_chain_wrapper when file is bigger than _DEFAULT_DOWNLOAD_CHUNK_SIZE

Can't Edit
Can't Publish+Mail
Start Review

Created:
5 years, 1 month ago by pierre.nury

Modified:
5 years, 1 month ago

Reviewers:
Mike Schwartz, thobrla

CC:
gs-team_google.com

Visibility:
Public.

More Reviews

Description

fix the daisy_chain_wrapper when file is bigger than _DEFAULT_DOWNLOAD_CHUNK_SIZE

Patch Set 1 #

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	gslib/daisy_chain_wrapper.py	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

pierre.nury

5 years, 1 month ago (2019-03-05 09:34:17 UTC) #1

The goal of the PR is to fix the file transfert between gs and aws. For me any
copy with file bigger than 100Mo was hanging indefinitely.
When transfering file bigger than _DEFAULT_DOWNLOAD_CHUNK_SIZE, the second
download for the checksum hangs because the stop_download threading event isn't
reset correctly.

Expand All Messages | Collapse All Messages