Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(370)

Issue 369810043: ns-3 mptcp

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 months, 1 week ago by kashif nadeem
Modified:
3 weeks ago
Reviewers:
vivelepourriel, trucanh524, annguyen
CC:
ns-3-reviews_googlegroups.com
Visibility:
Public.

Description

ns-3 mptcp

Patch Set 1 #

Total comments: 5

Patch Set 2 : Removed debug/redundant code and update coding style #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7899 lines, -72 lines) Patch
A src/internet/model/mptcp-crypto.h View 1 1 chunk +72 lines, -0 lines 0 comments Download
A src/internet/model/mptcp-crypto.cc View 1 1 chunk +75 lines, -0 lines 0 comments Download
A src/internet/model/mptcp-fullmesh.h View 1 1 chunk +71 lines, -0 lines 0 comments Download
A src/internet/model/mptcp-fullmesh.cc View 1 1 chunk +76 lines, -0 lines 0 comments Download
A src/internet/model/mptcp-mapping.h View 1 1 chunk +221 lines, -0 lines 0 comments Download
A src/internet/model/mptcp-mapping.cc View 1 1 chunk +262 lines, -0 lines 0 comments Download
A src/internet/model/mptcp-ndiffports.h View 1 1 chunk +78 lines, -0 lines 0 comments Download
A src/internet/model/mptcp-ndiffports.cc View 1 1 chunk +90 lines, -0 lines 0 comments Download
A src/internet/model/mptcp-scheduler.h View 1 1 chunk +68 lines, -0 lines 0 comments Download
A src/internet/model/mptcp-scheduler-fastest-rtt.h View 1 1 chunk +78 lines, -0 lines 0 comments Download
A src/internet/model/mptcp-scheduler-fastest-rtt.cc View 1 1 chunk +143 lines, -0 lines 0 comments Download
A src/internet/model/mptcp-scheduler-round-robin.h View 1 1 chunk +75 lines, -0 lines 0 comments Download
A src/internet/model/mptcp-scheduler-round-robin.cc View 1 1 chunk +125 lines, -0 lines 0 comments Download
A src/internet/model/mptcp-socket.h View 1 1 chunk +57 lines, -0 lines 0 comments Download
A src/internet/model/mptcp-socket-base.h View 1 1 chunk +519 lines, -0 lines 0 comments Download
A src/internet/model/mptcp-socket-base.cc View 1 1 chunk +1546 lines, -0 lines 0 comments Download
A src/internet/model/mptcp-subflow.h View 1 1 chunk +317 lines, -0 lines 0 comments Download
A src/internet/model/mptcp-subflow.cc View 1 1 chunk +1012 lines, -0 lines 0 comments Download
M src/internet/model/tcp-header.h View 1 2 chunks +29 lines, -0 lines 0 comments Download
M src/internet/model/tcp-header.cc View 4 chunks +17 lines, -2 lines 0 comments Download
M src/internet/model/tcp-l4-protocol.h View 1 5 chunks +19 lines, -9 lines 0 comments Download
M src/internet/model/tcp-l4-protocol.cc View 1 6 chunks +94 lines, -2 lines 0 comments Download
M src/internet/model/tcp-option.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/internet/model/tcp-option.cc View 1 chunk +2 lines, -1 line 0 comments Download
A src/internet/model/tcp-option-mptcp.h View 1 1 chunk +1000 lines, -0 lines 0 comments Download
A src/internet/model/tcp-option-mptcp.cc View 1 1 chunk +1409 lines, -0 lines 0 comments Download
M src/internet/model/tcp-rx-buffer.h View 1 1 chunk +6 lines, -0 lines 0 comments Download
M src/internet/model/tcp-rx-buffer.cc View 1 2 chunks +7 lines, -1 line 0 comments Download
M src/internet/model/tcp-socket-base.h View 1 30 chunks +99 lines, -32 lines 0 comments Download
M src/internet/model/tcp-socket-base.cc View 1 28 chunks +296 lines, -16 lines 0 comments Download
M src/internet/wscript View 4 chunks +20 lines, -0 lines 0 comments Download
M src/network/model/socket.h View 1 2 chunks +10 lines, -9 lines 0 comments Download
M src/network/utils/sequence-number.h View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 6
vivelepourriel
some comments https://codereview.appspot.com/369810043/diff/1/src/internet/model/mptcp-crypto.cc File src/internet/model/mptcp-crypto.cc (right): https://codereview.appspot.com/369810043/diff/1/src/internet/model/mptcp-crypto.cc#newcode61 src/internet/model/mptcp-crypto.cc:61: /* remove https://codereview.appspot.com/369810043/diff/1/src/internet/model/tcp-header.h File src/internet/model/tcp-header.h (right): https://codereview.appspot.com/369810043/diff/1/src/internet/model/tcp-header.h#newcode375 ...
2 months, 2 weeks ago (2018-09-04 07:14:58 UTC) #1
trucanh524
At a high level, I think the current patch misses the following: 1. Some examples ...
3 weeks ago (2018-10-27 08:51:46 UTC) #2
kashif nadeem
On 2018/10/27 08:51:46, trucanh524 wrote: > At a high level, I think the current patch ...
3 weeks ago (2018-10-27 13:32:34 UTC) #3
trucanh524
On 2018/10/27 13:32:34, kashif nadeem wrote: > On 2018/10/27 08:51:46, trucanh524 wrote: > > At ...
3 weeks ago (2018-10-27 14:14:16 UTC) #4
kashif nadeem
On 2018/10/27 14:14:16, trucanh524 wrote: > On 2018/10/27 13:32:34, kashif nadeem wrote: > > On ...
3 weeks ago (2018-10-27 14:23:44 UTC) #5
annguyen_ittc.ku.edu
3 weeks ago (2018-10-27 14:49:51 UTC) #6
I don't see the example after clicking on the link.

Best,

Anh


On Saturday, October 27, 2018, <kshfnadeem@gmail.com> wrote:

> On 2018/10/27 14:14:16, trucanh524 wrote:
>
>> On 2018/10/27 13:32:34, kashif nadeem wrote:
>> > On 2018/10/27 08:51:46, trucanh524 wrote:
>> > > At a high level, I think the current patch misses the following:
>> > >
>> > > 1. Some examples to show how to simulate the code
>> > > 2. Unit tests
>> > > 3. Documentation
>> > >
>> > > Could you please add them?
>> >
>> > Hi, truncanh524
>> >
>> > Thanks for reviewing my patch. I actually have example scripts
>>
>
> Do you want to update the patch with your example scripts first so
>>
> that I could
>
>> run and review the code in more details given that I have some time
>>
> this week?
>
> > but didn't yet
>> > created tests and documentation. I will try to create them and
>>
> upload them
>
>> here.
>>
>
> I suggest the documentation also includes all the features that you
>>
> have
>
>> implemented, features that are still missing (in comparison with the
>>
> RFC), and
>
>> the limitations (if any)of the code.  How many subflows the current
>>
> patch can
>
>> create?
>>
>
> Best,
>>
>
> Anh
>> >
>> > Regards,
>>
>
> Hi You can have example script from below link. I posted it in google
> groups because some people requested me for it. My code generates any
> number of flows. Normally 8 flows are recommended in literature per
> MPTCP connection. I will consider your advice while preparing
> documentation.
>
> https://groups.google.com/forum/#!searchin/ns-3-reviews/MPTC
> P$20patch$20is$20on$20codereview$20for$20Review$20process%
> 7Csort:date/ns-3-reviews/wtgm2E5yIU8/emHDjv9OBAAJ
>
> https://codereview.appspot.com/369810043/
>


-- 
----------------------------------------------------------------------------
*Truc Anh N. Nguyen*
annguyen@ittc.ku.edu      http://www.ittc.ku.edu/~annguyen
<http://www.ittc.ku.edu/~annguyen>
Information & Telecommunication Technology Center
Department of Electrical Engineering and Computer Science
The University of Kansas, Lawrence, KS 66045, USA
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b