Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(186)

Issue 369810043: ns-3 mptcp

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 month, 1 week ago by kashif nadeem
Modified:
2 weeks ago
Reviewers:
vivelepourriel
CC:
ns-3-reviews_googlegroups.com
Visibility:
Public.

Description

ns-3 mptcp

Patch Set 1 #

Total comments: 5

Patch Set 2 : Removed debug/redundant code and update coding style #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7899 lines, -72 lines) Patch
A src/internet/model/mptcp-crypto.h View 1 1 chunk +72 lines, -0 lines 0 comments Download
A src/internet/model/mptcp-crypto.cc View 1 1 chunk +75 lines, -0 lines 0 comments Download
A src/internet/model/mptcp-fullmesh.h View 1 1 chunk +71 lines, -0 lines 0 comments Download
A src/internet/model/mptcp-fullmesh.cc View 1 1 chunk +76 lines, -0 lines 0 comments Download
A src/internet/model/mptcp-mapping.h View 1 1 chunk +221 lines, -0 lines 0 comments Download
A src/internet/model/mptcp-mapping.cc View 1 1 chunk +262 lines, -0 lines 0 comments Download
A src/internet/model/mptcp-ndiffports.h View 1 1 chunk +78 lines, -0 lines 0 comments Download
A src/internet/model/mptcp-ndiffports.cc View 1 1 chunk +90 lines, -0 lines 0 comments Download
A src/internet/model/mptcp-scheduler.h View 1 1 chunk +68 lines, -0 lines 0 comments Download
A src/internet/model/mptcp-scheduler-fastest-rtt.h View 1 1 chunk +78 lines, -0 lines 0 comments Download
A src/internet/model/mptcp-scheduler-fastest-rtt.cc View 1 1 chunk +143 lines, -0 lines 0 comments Download
A src/internet/model/mptcp-scheduler-round-robin.h View 1 1 chunk +75 lines, -0 lines 0 comments Download
A src/internet/model/mptcp-scheduler-round-robin.cc View 1 1 chunk +125 lines, -0 lines 0 comments Download
A src/internet/model/mptcp-socket.h View 1 1 chunk +57 lines, -0 lines 0 comments Download
A src/internet/model/mptcp-socket-base.h View 1 1 chunk +519 lines, -0 lines 0 comments Download
A src/internet/model/mptcp-socket-base.cc View 1 1 chunk +1546 lines, -0 lines 0 comments Download
A src/internet/model/mptcp-subflow.h View 1 1 chunk +317 lines, -0 lines 0 comments Download
A src/internet/model/mptcp-subflow.cc View 1 1 chunk +1012 lines, -0 lines 0 comments Download
M src/internet/model/tcp-header.h View 1 2 chunks +29 lines, -0 lines 0 comments Download
M src/internet/model/tcp-header.cc View 4 chunks +17 lines, -2 lines 0 comments Download
M src/internet/model/tcp-l4-protocol.h View 1 5 chunks +19 lines, -9 lines 0 comments Download
M src/internet/model/tcp-l4-protocol.cc View 1 6 chunks +94 lines, -2 lines 0 comments Download
M src/internet/model/tcp-option.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/internet/model/tcp-option.cc View 1 chunk +2 lines, -1 line 0 comments Download
A src/internet/model/tcp-option-mptcp.h View 1 1 chunk +1000 lines, -0 lines 0 comments Download
A src/internet/model/tcp-option-mptcp.cc View 1 1 chunk +1409 lines, -0 lines 0 comments Download
M src/internet/model/tcp-rx-buffer.h View 1 1 chunk +6 lines, -0 lines 0 comments Download
M src/internet/model/tcp-rx-buffer.cc View 1 2 chunks +7 lines, -1 line 0 comments Download
M src/internet/model/tcp-socket-base.h View 1 30 chunks +99 lines, -32 lines 0 comments Download
M src/internet/model/tcp-socket-base.cc View 1 28 chunks +296 lines, -16 lines 0 comments Download
M src/internet/wscript View 4 chunks +20 lines, -0 lines 0 comments Download
M src/network/model/socket.h View 1 2 chunks +10 lines, -9 lines 0 comments Download
M src/network/utils/sequence-number.h View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 1
vivelepourriel
2 weeks, 1 day ago (2018-09-04 07:14:58 UTC) #1
some comments

https://codereview.appspot.com/369810043/diff/1/src/internet/model/mptcp-cryp...
File src/internet/model/mptcp-crypto.cc (right):

https://codereview.appspot.com/369810043/diff/1/src/internet/model/mptcp-cryp...
src/internet/model/mptcp-crypto.cc:61: /*
remove

https://codereview.appspot.com/369810043/diff/1/src/internet/model/tcp-header.h
File src/internet/model/tcp-header.h (right):

https://codereview.appspot.com/369810043/diff/1/src/internet/model/tcp-header...
src/internet/model/tcp-header.h:375: for
(TcpHeader::TcpOptionList::const_iterator it = l.begin (); it != l.end (); ++it)
this is not mandatory but now that ns3 supports c++11, you may be able to update
the code to c++11 standards with for(auto it. ...)

https://codereview.appspot.com/369810043/diff/1/src/internet/model/tcp-header...
src/internet/model/tcp-header.h:378: //                    << " with " <<
T::GetTypeId().GetName()
remove comments !

https://codereview.appspot.com/369810043/diff/1/src/internet/model/tcp-l4-pro...
File src/internet/model/tcp-l4-protocol.cc (right):

https://codereview.appspot.com/369810043/diff/1/src/internet/model/tcp-l4-pro...
src/internet/model/tcp-l4-protocol.cc:808: )
this function is just for debug. Either remove it or call it only within #ifdef
DEBUG #endif

https://codereview.appspot.com/369810043/diff/1/src/internet/model/tcp-option.h
File src/internet/model/tcp-option.h (right):

https://codereview.appspot.com/369810043/diff/1/src/internet/model/tcp-option...
src/internet/model/tcp-option.h:64: MPTCP = 30,   //! Multipath TCP options
share the same Kind
align comment
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b