Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(737)

Issue 369810043: ns-3 mptcp

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years ago by kashif nadeem
Modified:
4 months, 2 weeks ago
CC:
ns-3-reviews_googlegroups.com
Visibility:
Public.

Description

ns-3 mptcp

Patch Set 1 #

Total comments: 5

Patch Set 2 : Removed debug/redundant code and update coding style #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7899 lines, -72 lines) Patch
A src/internet/model/mptcp-crypto.h View 1 1 chunk +72 lines, -0 lines 0 comments Download
A src/internet/model/mptcp-crypto.cc View 1 1 chunk +75 lines, -0 lines 0 comments Download
A src/internet/model/mptcp-fullmesh.h View 1 1 chunk +71 lines, -0 lines 0 comments Download
A src/internet/model/mptcp-fullmesh.cc View 1 1 chunk +76 lines, -0 lines 0 comments Download
A src/internet/model/mptcp-mapping.h View 1 1 chunk +221 lines, -0 lines 0 comments Download
A src/internet/model/mptcp-mapping.cc View 1 1 chunk +262 lines, -0 lines 0 comments Download
A src/internet/model/mptcp-ndiffports.h View 1 1 chunk +78 lines, -0 lines 0 comments Download
A src/internet/model/mptcp-ndiffports.cc View 1 1 chunk +90 lines, -0 lines 0 comments Download
A src/internet/model/mptcp-scheduler.h View 1 1 chunk +68 lines, -0 lines 0 comments Download
A src/internet/model/mptcp-scheduler-fastest-rtt.h View 1 1 chunk +78 lines, -0 lines 0 comments Download
A src/internet/model/mptcp-scheduler-fastest-rtt.cc View 1 1 chunk +143 lines, -0 lines 0 comments Download
A src/internet/model/mptcp-scheduler-round-robin.h View 1 1 chunk +75 lines, -0 lines 0 comments Download
A src/internet/model/mptcp-scheduler-round-robin.cc View 1 1 chunk +125 lines, -0 lines 0 comments Download
A src/internet/model/mptcp-socket.h View 1 1 chunk +57 lines, -0 lines 0 comments Download
A src/internet/model/mptcp-socket-base.h View 1 1 chunk +519 lines, -0 lines 0 comments Download
A src/internet/model/mptcp-socket-base.cc View 1 1 chunk +1546 lines, -0 lines 0 comments Download
A src/internet/model/mptcp-subflow.h View 1 1 chunk +317 lines, -0 lines 0 comments Download
A src/internet/model/mptcp-subflow.cc View 1 1 chunk +1012 lines, -0 lines 0 comments Download
M src/internet/model/tcp-header.h View 1 2 chunks +29 lines, -0 lines 0 comments Download
M src/internet/model/tcp-header.cc View 4 chunks +17 lines, -2 lines 0 comments Download
M src/internet/model/tcp-l4-protocol.h View 1 5 chunks +19 lines, -9 lines 0 comments Download
M src/internet/model/tcp-l4-protocol.cc View 1 6 chunks +94 lines, -2 lines 0 comments Download
M src/internet/model/tcp-option.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/internet/model/tcp-option.cc View 1 chunk +2 lines, -1 line 0 comments Download
A src/internet/model/tcp-option-mptcp.h View 1 1 chunk +1000 lines, -0 lines 0 comments Download
A src/internet/model/tcp-option-mptcp.cc View 1 1 chunk +1409 lines, -0 lines 0 comments Download
M src/internet/model/tcp-rx-buffer.h View 1 1 chunk +6 lines, -0 lines 0 comments Download
M src/internet/model/tcp-rx-buffer.cc View 1 2 chunks +7 lines, -1 line 0 comments Download
M src/internet/model/tcp-socket-base.h View 1 30 chunks +99 lines, -32 lines 0 comments Download
M src/internet/model/tcp-socket-base.cc View 1 28 chunks +296 lines, -16 lines 0 comments Download
M src/internet/wscript View 4 chunks +20 lines, -0 lines 0 comments Download
M src/network/model/socket.h View 1 2 chunks +10 lines, -9 lines 0 comments Download
M src/network/utils/sequence-number.h View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 16
vivelepourriel
some comments https://codereview.appspot.com/369810043/diff/1/src/internet/model/mptcp-crypto.cc File src/internet/model/mptcp-crypto.cc (right): https://codereview.appspot.com/369810043/diff/1/src/internet/model/mptcp-crypto.cc#newcode61 src/internet/model/mptcp-crypto.cc:61: /* remove https://codereview.appspot.com/369810043/diff/1/src/internet/model/tcp-header.h File src/internet/model/tcp-header.h (right): https://codereview.appspot.com/369810043/diff/1/src/internet/model/tcp-header.h#newcode375 ...
1 year, 11 months ago (2018-09-04 07:14:58 UTC) #1
trucanh524
At a high level, I think the current patch misses the following: 1. Some examples ...
1 year, 9 months ago (2018-10-27 08:51:46 UTC) #2
kashif nadeem
On 2018/10/27 08:51:46, trucanh524 wrote: > At a high level, I think the current patch ...
1 year, 9 months ago (2018-10-27 13:32:34 UTC) #3
trucanh524
On 2018/10/27 13:32:34, kashif nadeem wrote: > On 2018/10/27 08:51:46, trucanh524 wrote: > > At ...
1 year, 9 months ago (2018-10-27 14:14:16 UTC) #4
kashif nadeem
On 2018/10/27 14:14:16, trucanh524 wrote: > On 2018/10/27 13:32:34, kashif nadeem wrote: > > On ...
1 year, 9 months ago (2018-10-27 14:23:44 UTC) #5
annguyen_ittc.ku.edu
I don't see the example after clicking on the link. Best, Anh On Saturday, October ...
1 year, 9 months ago (2018-10-27 14:49:51 UTC) #6
n.p
Hi, That's a huge work. It is impossible to review it in one time, and ...
1 year, 8 months ago (2018-12-06 18:22:48 UTC) #7
kashif nadeem
On 2018/12/06 18:22:48, n.p wrote: > Hi, > > That's a huge work. It is ...
1 year, 8 months ago (2018-12-11 21:03:06 UTC) #8
Francis Lee
Hi, I have downloaded the patch and compiled MPTCP successfully in ns-3.28. MPTCP works well ...
1 year, 7 months ago (2018-12-19 14:05:11 UTC) #9
kashif nadeem
Hi, I guess the problem is with your script and topology. MPTCP connection/flow isn’t getting ...
1 year, 7 months ago (2018-12-19 15:51:39 UTC) #10
rqzhangxd
Hi kashif: These days, I have to compare the performance of the tcp and mptcp, ...
1 year, 7 months ago (2019-01-06 01:51:30 UTC) #11
rqzhangxd
Hi kashif: These days, I have to compare the performance of the tcp and mptcp, ...
1 year, 7 months ago (2019-01-06 01:52:34 UTC) #12
1129190026
On 2019/01/06 01:52:34, rqzhangxd wrote: > Hi kashif: > These days, I have to compare ...
1 year, 4 months ago (2019-04-16 07:27:00 UTC) #13
1129190026
On 2019/01/06 01:52:34, rqzhangxd wrote: > Hi kashif: > These days, I have to compare ...
1 year, 4 months ago (2019-04-16 07:27:33 UTC) #14
ytxing96
On 2018/12/19 14:05:11, Francis Lee wrote: > Hi, > > I have downloaded the patch ...
4 months, 3 weeks ago (2020-03-22 16:20:03 UTC) #15
L.P. Verma
4 months, 2 weeks ago (2020-03-26 05:10:50 UTC) #16
On 2020/03/22 16:20:03, ytxing96 wrote:
> On 2018/12/19 14:05:11, Francis Lee wrote:
> > Hi,
> > 
> > I have downloaded the patch and compiled MPTCP successfully in ns-3.28.
MPTCP
> > works well when I run the example "mptcp-example.cc" but when I try to test
> > MPTCP in a spine-leaf topology,  the simulation ends with:
> > ...
> > ==== Dumping list of mappings ====
> > ==== End of dump ====
> > 
> > msg="Could not find mapping associated to ssn",
> > file=../src/internet/model/mptcp-subflow.cc, line=289
> > terminate called without an active exception
> > 
> > Sorry I don't spend much time to check the code. I wonder what are the
> possible
> > reasons for this failure?
> > 
> > Thank you so much.
> > 
> > Best,
> > Francis
> 
> Hi
> 
> I encounter the same issue. Do you have any idea how this could be solved?
> 
> Thanks.

Hello Francis,
I am  also facing same issue, when I tried to run mptcp-example.cc, the
simulation ends with:
> ...
> > ==== Dumping list of mappings ====
> > ==== End of dump ====
are you have solution for same. If yes, kindly help me remove this error.
With Best Regard
L. P Verma
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b