Issue 36980043: StartContainer returns hardware characteristics.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 36980043: StartContainer returns hardware characteristics.

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 5 months ago by thumper

Modified:
10 years, 5 months ago

Reviewers:
mp+197644, wallyworld

Visibility:
Public.

Description

StartContainer returns hardware characteristics. Initial change to have the hardware characteristics of containers returned. At this stage just the arch is filled out. https://code.launchpad.net/~thumper/juju-core/container-hardware-characteristics/+merge/197644 Requires: https://code.launchpad.net/~thumper/juju-core/kvm-provisioner/+merge/197629 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 1

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+42 lines, -28 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	container/interface.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	container/kvm/kvm.go	View	2 chunks	+10 lines, -6 lines	0 comments	Download
M	container/kvm/live_test.go	View	1 chunk	+4 lines, -2 lines	1 comment	Download
M	container/lxc/lxc.go	View	5 chunks	+14 lines, -9 lines	0 comments	Download
M	container/testing/common.go	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	provider/local/environ.go	View	1 chunk	+2 lines, -3 lines	0 comments	Download
M	worker/provisioner/kvm-broker.go	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	worker/provisioner/lxc-broker.go	View	1 chunk	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

wallyworld

10 years, 5 months ago (2013-12-04 04:44:10 UTC) #2

LGTM but I'd like to see the tests more proscriptive. eg we know what arch has
to be so test that rather than no nil.

https://codereview.appspot.com/36980043/diff/1/container/kvm/live_test.go
File container/kvm/live_test.go (right):

https://codereview.appspot.com/36980043/diff/1/container/kvm/live_test.go#new...
container/kvm/live_test.go:101: c.Assert(hardware, gc.Not(gc.Equals),
&instance.HardwareCharacteristics{})
I do think we should be asserting an actual expected value, not just "not nil"

Expand All Messages | Collapse All Messages