Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1660)

Issue 369750043: Various fixes to GUB: - update broken download links - add missing dependencies - fix building o…

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 months ago by knupero
Modified:
2 months, 2 weeks ago
Reviewers:
trueroad, lemzwerg, carl.d.sorensen
Visibility:
Public.

Description

Various fixes to GUB: - update broken download links - add missing dependencies - fix building of 'make' on glibc 2.27 systems - teach our ancient glibc that make 4.x exists - minor fixes Signed-off-by: Knut Petersen <knut_petersen@t-online.de>

Patch Set 1 #

Total comments: 7

Patch Set 2 : 2nd version of GUB patch set, fix gmake segfaulting on glibc 2.27 #

Patch Set 3 : Fix the 'db delete failing' problem. Needed at least for openSuSE Tumbleweed. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -6 lines) Patch
M gub/gup.py View 1 2 1 chunk +1 line, -1 line 0 comments Download
M gub/specs/darwin/cross/gcc.py View 1 chunk +1 line, -1 line 0 comments Download
M gub/specs/darwin/odcctools.py View 1 chunk +1 line, -1 line 0 comments Download
M gub/specs/ghostscript.py View 1 chunk +1 line, -1 line 0 comments Download
M gub/specs/git.py View 1 chunk +1 line, -1 line 0 comments Download
M gub/specs/glibc.py View 1 chunk +1 line, -0 lines 0 comments Download
M gub/specs/libpng.py View 1 chunk +1 line, -1 line 0 comments Download
M gub/specs/lilypond.py View 1 chunk +1 line, -0 lines 0 comments Download
M gub/specs/make.py View 1 1 chunk +1 line, -0 lines 0 comments Download
A patches/glibc-allow-make4.patch View 1 chunk +11 lines, -0 lines 0 comments Download
A patches/make_glob2.patch View 1 1 chunk +77 lines, -0 lines 0 comments Download

Messages

Total messages: 8
lemzwerg
LGTM, thanks! https://codereview.appspot.com/369750043/diff/1/gub/specs/ghostscript.py File gub/specs/ghostscript.py (right): https://codereview.appspot.com/369750043/diff/1/gub/specs/ghostscript.py#newcode305 gub/specs/ghostscript.py:305: source = 'https://ftp.osuosl.org/pub/blfs/conglomeration/ghostscript/ghostscript-9.15.tar.bz2' Why exactly this host? ...
3 months ago (2018-07-16 17:14:05 UTC) #1
knupero
https://codereview.appspot.com/369750043/diff/1/gub/specs/ghostscript.py File gub/specs/ghostscript.py (right): https://codereview.appspot.com/369750043/diff/1/gub/specs/ghostscript.py#newcode305 gub/specs/ghostscript.py:305: source = 'https://ftp.osuosl.org/pub/blfs/conglomeration/ghostscript/ghostscript-9.15.tar.bz2' On 2018/07/16 17:14:05, lemzwerg wrote: > ...
3 months ago (2018-07-16 17:30:11 UTC) #2
knupero
Please review
3 months ago (2018-07-16 17:33:06 UTC) #3
Carl
Thank you for doing this! Looks good to me. Carl
3 months ago (2018-07-16 17:53:43 UTC) #4
trueroad
LGTM except the followings. Thank you. https://codereview.appspot.com/369750043/diff/1/gub/specs/ghostscript.py File gub/specs/ghostscript.py (right): https://codereview.appspot.com/369750043/diff/1/gub/specs/ghostscript.py#newcode305 gub/specs/ghostscript.py:305: source = 'https://ftp.osuosl.org/pub/blfs/conglomeration/ghostscript/ghostscript-9.15.tar.bz2' ...
3 months ago (2018-07-17 12:05:42 UTC) #5
knupero
There will be a 2nd version, but not today and not tomorrow ... https://codereview.appspot.com/369750043/diff/1/gub/specs/ghostscript.py File ...
3 months ago (2018-07-17 21:49:12 UTC) #6
knupero
2nd version of GUB patch set, fix gmake segfaulting on glibc 2.27
2 months, 4 weeks ago (2018-07-19 09:26:59 UTC) #7
knupero
2 months, 2 weeks ago (2018-07-27 22:13:48 UTC) #8
Fix the 'db delete failing' problem. Needed at least for openSuSE Tumbleweed.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b