Issue 36910043: Hook up the kvm broker and provisioner

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 36910043: Hook up the kvm broker and provisioner

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 5 months ago by thumper

Modified:
10 years, 5 months ago

Reviewers:
mp+197629, wallyworld

Visibility:
Public.

Description

Hook up the kvm broker and provisioner This branch adds a kvm broker and hooks it up to the existing container initialization. The cpu-checker package is added to every machine to allow kvm-ok to be executed. A few drive by fixes related to kvm: * added a default bridge, used by the broker when there is no other config. * the container wasn't removing the container dir * the kvm package isn't actually needed * the local provider was setting the wrong container type (in the case of kvm) https://code.launchpad.net/~thumper/juju-core/kvm-provisioner/+merge/197629 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Hook up the kvm broker and provisioner #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+389 lines, -5 lines)			Patch
A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	container/kvm/initialisation.go	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	container/kvm/kvm.go	View		2 chunks	+6 lines, -1 line	0 comments	Download
M	environs/cloudinit/cloudinit.go	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	provider/local/environ.go	View		1 chunk	+1 line, -1 line	0 comments	Download
M	worker/provisioner/container_initialisation.go	View		1 chunk	+5 lines, -1 line	0 comments	Download
M	worker/provisioner/container_initialisation_test.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
A	worker/provisioner/kvm-broker.go	View		1 chunk	+117 lines, -0 lines	0 comments	Download
A	worker/provisioner/kvm-broker_test.go	View		1 chunk	+256 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

wallyworld

10 years, 5 months ago (2013-12-04 03:43:20 UTC) #3

LGTM
Please add a todo to factor out the common lxc and kvm code in the respective
brokers. And a todo to sort out the kvm bridge stuff. I know there's a comment
but a todo is better.

Expand All Messages | Collapse All Messages