code review 36880043: freetype/truetype: fix MD0/MD1 opcodes and f26dot6 mult...

freetype/truetype: fix MD0/MD1 opcodes and f26dot6 multiplication
rounding.

Pass all the hinting tests. Hooray! Removing the hintingBrokenAt field
will be a follow-up CL.

[nigeltao, 2013-12-04 00:13:56]

Hello bsiegert@gmail.com, remyoudompheng@gmail.com (cc:
golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/freetype-go

[nigeltao, 2013-12-04 00:18:04]

Remy: in https://codereview.appspot.com/16440043/ you originally had the "zp0==0
|| zp1==0" check but say that it gave the wrong points for Adobe Source Sans
Pro. Can you confirm that this CL still looks good on that font?

It seems that that previous CL erroneously translated the C code "CUR.opcode &
1" as the Go code "opcode == opMD1" instead of "opcode == opMD0". Confusingly,
opMD0 is 0x49, opMD1 is 0x4a.

[remyoudompheng, 2013-12-04 06:58:09]

No regression observed on the Source * Pro fonts.

There is still a rounding issue on Source Sans Pro Bold Italic, but it's there
for a long time (and happens in unhinted mode).

[bsiegert, 2013-12-04 11:57:44]

LGTM

yay!

[jnj, 2013-12-04 17:25:24]

On 2013/12/04 00:13:56, nigeltao wrote:
> Hello mailto:bsiegert@gmail.com, mailto:remyoudompheng@gmail.com (cc:
> mailto:golang-dev@googlegroups.com),
> 
> I'd like you to review this change to
> https://code.google.com/p/freetype-go

Congrats on getting all the hinting tests passing.

-a happy freetype-go user

[nigeltao, 2013-12-04 22:09:17]

*** Submitted as
https://code.google.com/p/freetype-go/source/detail?r=b59b8c2ec13c ***

freetype/truetype: fix MD0/MD1 opcodes and f26dot6 multiplication
rounding.

Pass all the hinting tests. Hooray! Removing the hintingBrokenAt field
will be a follow-up CL.

R=bsiegert, remyoudompheng, jeremyjackins
CC=golang-dev
https://codereview.appspot.com/36880043

[nigeltao, 2013-12-04 22:22:57]

On Wed, Dec 4, 2013 at 5:58 PM,  <remyoudompheng@gmail.com> wrote:
> There is still a rounding issue on Source Sans Pro Bold Italic, but it's
> there for a long time (and happens in unhinted mode).

Remy: at what size?

[nigeltao, 2013-12-19 21:46:27]

On Thu, Dec 5, 2013 at 9:22 AM, Nigel Tao <nigeltao@golang.org> wrote:
> On Wed, Dec 4, 2013 at 5:58 PM,  <remyoudompheng@gmail.com> wrote:
>> There is still a rounding issue on Source Sans Pro Bold Italic, but it's
>> there for a long time (and happens in unhinted mode).
>
> Remy: at what size?

Remy: can you give more details? I am unable to reproduce this.