Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1103)

Issue 3684043: Review: remove stray stderr outputs (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 4 months ago by larrygritz
Modified:
13 years, 4 months ago
Reviewers:
oiio-dev
Base URL:
http://svn.openimageio.org/oiio/trunk/
Visibility:
Public.

Description

Removed a couple unguarded outputs to std::cerr, as well as many commented-out and no longer needed status outputs. Note that there are still some uses of std::cerr, but it's my belief that they only exist in #ifdef DEBUG kinds of situations. The general rule is that our *libraries* should never output to stdout or stderr, except for DEBUG mode. All errors should be bubbled up via the approved error reporting methods error/geterror, etc. Binaries specifically meant to be run on the command line, such as iinfo, may use stdout and stderr per usual conventions for command line utilities.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -31 lines) Patch
src/libOpenImageIO/imageio.cpp View 3 chunks +3 lines, -6 lines 0 comments Download
src/libOpenImageIO/imageioplugin.cpp View 7 chunks +3 lines, -25 lines 0 comments Download

Messages

Total messages: 1
larrygritz
13 years, 4 months ago (2010-12-16 06:02:36 UTC) #1

          
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b