Issue 3684042: Review: ImageInput::read_image allocation bug

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3684042: Review: ImageInput::read_image allocation bug (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 4 months ago by larrygritz

Modified:
13 years, 4 months ago

Reviewers:
oiio-dev, solomon.boulos

Base URL:
http://svn.openimageio.org/oiio/trunk/

Visibility:
Public.

Description

ImageInput::read_image allocated the wrong size buffer where it stores individual scanlines or tiles -- for non-native reading, it needs to allocate pixels of the size the user requested, not the size of the data in the file. (Jeremy, this is your bug. It wasn't specific to OpenEXR.)

Patch Set 1 #

Total comments: 1

Created: 13 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -1 line)			Patch
		src/libOpenImageIO/imageinput.cpp	View		1 chunk	+5 lines, -1 line	1 comment	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

solomon.boulos

13 years, 4 months ago (2010-12-16 18:49:57 UTC) #2

http://codereview.appspot.com/3684042/diff/1/src/libOpenImageIO/imageinput.cpp
File src/libOpenImageIO/imageinput.cpp (right):

http://codereview.appspot.com/3684042/diff/1/src/libOpenImageIO/imageinput.cp...
src/libOpenImageIO/imageinput.cpp:167: stride_t pixel_bytes;
As a minor nit, unless you think you'll do more stuff in the if/else block, I'd
prefer a ternary initialization here (in this case it would look cleaner to my
eyes).

Expand All Messages | Collapse All Messages