Issue 36690043: Fix: Removing units throws notification error

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 36690043: Fix: Removing units throws notification error

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 4 months ago by jeff.pihach

Modified:
10 years, 4 months ago

Reviewers:
matthew.scott, mp+197597

Visibility:
Public.

Description

Fix: Removing units throws notification error Removing units in the sandbox and in a real environment no longer always throws an error. https://code.launchpad.net/~hatch/juju-gui/num-units-1253113/+merge/197597 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Fix: Removing units throws notification error #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+118 lines, -7 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	app/store/env/fakebackend.js	View	4 chunks	+5 lines, -4 lines	0 comments	Download
M	app/store/env/sandbox.js	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/test_fakebackend.js	View	1 chunk	+108 lines, -0 lines	0 comments	Download
M	test/test_sandbox_go.js	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

jeff.pihach

10 years, 4 months ago (2013-12-03 21:27:34 UTC) #4

*** Submitted:

Fix: Removing units throws notification error

Removing units in the sandbox and in a real environment no longer
always throws an error.

R=matthew.scott
CC=
https://codereview.appspot.com/36690043

Expand All Messages | Collapse All Messages