Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(154)

Issue 365800043: Typos found by checking clang warnings.

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 week, 6 days ago by lemzwerg
Modified:
1 week, 6 days ago
Reviewers:
dak
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Typos found by checking clang warnings.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M lily/accidental-engraver.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M lily/page-spacing.cc View 1 chunk +1 line, -1 line 0 comments Download
M lily/vaticana-ligature-engraver.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2
dak
All three look indeed like typos, but all three look like they will have significant ...
1 week, 6 days ago (2018-11-04 23:11:20 UTC) #1
lemzwerg
1 week, 6 days ago (2018-11-04 23:22:14 UTC) #2
On 2018/11/04 23:11:20, dak wrote:
> All three look indeed like typos, but all three look like they will have
> significant effects warranting individual testing and likely a regtest.  So
> while that looks bothersome, it might make sense turning this into three
> separate issues.

Basically I agree.  However, I would like to see first what kind of changes the
fixes cause so that sensible descriptions are possible for another round of
refinements.  As mentioned earlier, I have no idea what will happen.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b