Issue 365800043: Typos found by checking clang warnings.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 365800043: Typos found by checking clang warnings.

Can't Edit
Can't Publish+Mail
Start Review

Created:
5 years, 5 months ago by lemzwerg

Modified:
5 years, 5 months ago

Reviewers:
dak

CC:
lilypond-devel_gnu.org

Visibility:
Public.

More Reviews

Description

Typos found by checking clang warnings.

Patch Set 1 #

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+4 lines, -4 lines)			Patch
M	lily/accidental-engraver.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	lily/page-spacing.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	lily/vaticana-ligature-engraver.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

dak

All three look indeed like typos, but all three look like they will have significant ...

5 years, 5 months ago (2018-11-04 23:11:20 UTC) #1

lemzwerg

5 years, 5 months ago (2018-11-04 23:22:14 UTC) #2

On 2018/11/04 23:11:20, dak wrote:
> All three look indeed like typos, but all three look like they will have
> significant effects warranting individual testing and likely a regtest.  So
> while that looks bothersome, it might make sense turning this into three
> separate issues.

Basically I agree.  However, I would like to see first what kind of changes the
fixes cause so that sensible descriptions are possible for another round of
refinements.  As mentioned earlier, I have no idea what will happen.

Expand All Messages | Collapse All Messages