Issue 36520044: code review 36520044: gosshnew/ssh: add more diagnostics to Marshal/Unmarshal...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 36520044: code review 36520044: gosshnew/ssh: add more diagnostics to Marshal/Unmarshal... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 5 months ago by hanwen-google

Modified:
12 years, 5 months ago

Reviewers:
agl1, jpsugar

CC:
agl1, dave_cheney.net, jpsugar, golang-dev, hanwen-google

Visibility:
Public.

Description

gosshnew/ssh: add more diagnostics to Marshal/Unmarshal failures

Patch Set 1 #

Patch Set 2 : diff -r 5204c62e7184 https://hanwen%40google.com@code.google.com/p/gosshnew/ #

Patch Set 3 : diff -r 5204c62e7184 https://hanwen%40google.com@code.google.com/p/gosshnew/ #

Patch Set 4 : diff -r 5204c62e7184 https://hanwen%40google.com@code.google.com/p/gosshnew/ #

Created: 12 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -7 lines)			Patch
	M	ssh/messages.go	View	1	6 chunks	+7 lines, -7 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

hanwen-google

Hello agl1, dave@cheney.net, jpsugar@google.com (cc: agl@golang.org, dave@cheney.net, golang-dev@googlegroups.com, hanwen@google.com, jpsugar@google.com), I'd like you to review ...

12 years, 5 months ago (2013-12-18 10:56:17 UTC) #1

hanwen-google

12 years, 5 months ago (2013-12-19 09:38:13 UTC) #4

*** Submitted as https://code.google.com/p/gosshnew/source/detail?r=b78c3da92890
***

gosshnew/ssh: add more diagnostics to Marshal/Unmarshal failures

R=agl, dave, jpsugar
CC=agl, dave, golang-dev, hanwen, jpsugar
https://codereview.appspot.com/36520044

Expand All Messages | Collapse All Messages