Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3806)

Issue 36480048: Enable manual-specific styling of documentation; issue 3714

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 4 months ago by Carl P.
Modified:
10 years, 4 months ago
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Enable manual-specific styling of documentation; issue 3714 Providing capability for the CSS stylesheet to "see" which manual is being used and the development status of the manual for styling purposes. Adds classes to the HTML <body> tag based on the filename of the manual, as well as a (currently) hard-coded value for development status. Comments follow based on individual patches, in reverse order == Add comments to lilypond-texi2html.init Adding inline comments to lilypond-texi2html.init to explain the added lines of code in the file to enable the manual-specific CSS styling. Also cleaned up the code indentation levels. == CSS changes to color-code major manuals Added styling to use a manual-specific class in the <body> tag to color code each of the major manuals. Now: * Learning Manual: Green book * Notation Reference: Blue book * Usage Manual: Yellow book * Extending: Red book * Internals Reference: Purple book * Contributor's Guide: Black book == Add classes to <body> tag of documentation files To facilitate request from lilypond-user to facilitate differentiating among the various manuals, appending CSS classes to the <body> tag of the documentation files so that the main CSS stylesheet can be modified to look for those classes to specifically style each manual and development status. The present solution for indicating development status is a hardcoded line in Documentation/lilypond-texi2html.init.

Patch Set 1 #

Total comments: 1

Patch Set 2 : Remove duplicate definitions from lilypond-manuals.css file, per review #

Patch Set 3 : issue 3714, adjust sidebar colors for legibility and contrast #

Patch Set 4 : Issue 3714, follow-up changes to CSS colors for manuals based on feedback from reviewers. Changing … #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -11 lines) Patch
M Documentation/css/lilypond-manuals.css View 1 2 3 10 chunks +81 lines, -11 lines 0 comments Download
M Documentation/lilypond-texi2html.init View 1 chunk +19 lines, -0 lines 0 comments Download

Messages

Total messages: 10
Carl P.
Patch for initial solution to issue 3714, regarding color-coding of manuals. This patch color codes ...
10 years, 4 months ago (2013-12-12 06:06:04 UTC) #1
lemzwerg
LGTM, with one small nit. https://codereview.appspot.com/36480048/diff/1/Documentation/css/lilypond-manuals.css File Documentation/css/lilypond-manuals.css (right): https://codereview.appspot.com/36480048/diff/1/Documentation/css/lilypond-manuals.css#newcode456 Documentation/css/lilypond-manuals.css:456: body.learning { background-color: #ccffcc; ...
10 years, 4 months ago (2013-12-12 07:21:36 UTC) #2
Trevor Daniels
LGTM, although it is difficult to visualise the effect of the various colours without seeing ...
10 years, 4 months ago (2013-12-12 09:10:29 UTC) #3
Carl P.
On Thu, Dec 12, 2013 at 2:21 AM, <lemzwerg@googlemail.com> wrote: > LGTM, with one small ...
10 years, 4 months ago (2013-12-12 12:49:03 UTC) #4
Carl P.
On Thu, Dec 12, 2013 at 7:49 AM, Carl Peterson <carlopeterson@gmail.com>wrote: > On Thu, Dec ...
10 years, 4 months ago (2013-12-12 13:15:56 UTC) #5
Carl P.
On Thu, Dec 12, 2013 at 4:10 AM, <tdanielsmusic@googlemail.com> wrote: > LGTM, although it is ...
10 years, 4 months ago (2013-12-12 13:16:40 UTC) #6
Carl P.
Remove duplicate definitions from lilypond-manuals.css file, per review
10 years, 4 months ago (2013-12-12 22:24:41 UTC) #7
Carl P.
issue 3714, adjust sidebar colors for legibility and contrast
10 years, 4 months ago (2013-12-12 22:50:05 UTC) #8
Carl
On 2013/12/12 22:50:05, Carl P. wrote: > issue 3714, adjust sidebar colors for legibility and ...
10 years, 4 months ago (2013-12-13 00:36:42 UTC) #9
Carl P.
10 years, 4 months ago (2013-12-14 05:51:58 UTC) #10
Issue 3714, follow-up changes to CSS colors for manuals based on feedback from
reviewers. Changing to white background with light TOC sidebar.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b