Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1884)

Issue 36440043: pub.dart compiling with stubs for io.dart. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 4 months ago by pajamallama
Modified:
10 years, 3 months ago
Reviewers:
CC:
tapted_google.com
Base URL:
git@github.com:Pat-Laub/pub.git@master
Visibility:
Public.

Description

pub.dart compiling with stubs for io.dart. Now pub.dart is compiling (at least the files needed for 'pub get'). The tests are not though, as 'package:scheduled_test' is not able to be compiled to JS. All directory/files currently ignored are prefixed by '_'. These will not compile under dart2js: dart:io dart:http package:analyzer (relies on dart:io) package:barback (relies on dart:io) package:http (relies on dart:io) package:oauth2 (relies on package:http/src/* which rely on dart:io) package:scheduled_test (relies on dart:io) package:watcher (relies on dart:io) Extract files that will be used for 'get' command; all non-'get' files are prefixed with '_'. References to 'dart:io', 'dart:http', 'http.dart' are all removed. Also Platform dependent code is commented out.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -9221 lines) Patch
lib/src/barback.dart View 1 chunk +0 lines, -313 lines 0 comments Download
lib/src/barback/dart2js_transformer.dart View 1 chunk +0 lines, -275 lines 0 comments Download
lib/src/barback/dart_forwarding_transformer.dart View 1 chunk +0 lines, -36 lines 0 comments Download
lib/src/barback/load_all_transformers.dart View 1 chunk +0 lines, -279 lines 0 comments Download
lib/src/barback/load_transformers.dart View 1 chunk +0 lines, -578 lines 0 comments Download
lib/src/barback/pub_package_provider.dart View 1 chunk +0 lines, -27 lines 0 comments Download
lib/src/barback/rewrite_import_transformer.dart View 1 chunk +0 lines, -47 lines 0 comments Download
lib/src/barback/server.dart View 1 chunk +0 lines, -304 lines 0 comments Download
lib/src/barback/sources.dart View 1 chunk +0 lines, -152 lines 0 comments Download
lib/src/command/build.dart View 1 chunk +0 lines, -156 lines 0 comments Download
lib/src/command/cache.dart View 1 chunk +0 lines, -51 lines 0 comments Download
lib/src/command/help.dart View 1 chunk +0 lines, -36 lines 0 comments Download
lib/src/command/lish.dart View 1 chunk +0 lines, -177 lines 0 comments Download
lib/src/command/list_package_dirs.dart View 1 chunk +0 lines, -62 lines 0 comments Download
lib/src/command/serve.dart View 1 chunk +0 lines, -133 lines 0 comments Download
lib/src/command/upgrade.dart View 1 chunk +0 lines, -44 lines 0 comments Download
lib/src/command/uploader.dart View 1 chunk +0 lines, -84 lines 0 comments Download
lib/src/command/version.dart View 1 chunk +0 lines, -22 lines 0 comments Download
lib/src/dart.dart View 1 chunk +0 lines, -190 lines 0 comments Download
lib/src/git.dart View 1 chunk +0 lines, -74 lines 0 comments Download
lib/src/http.dart View 1 chunk +0 lines, -229 lines 0 comments Download
lib/src/oauth2.dart View 1 chunk +0 lines, -205 lines 0 comments Download
lib/src/safe_http_server.dart View 1 chunk +0 lines, -169 lines 0 comments Download
lib/src/sdk.dart View 1 chunk +0 lines, -68 lines 0 comments Download
lib/src/source/git.dart View 1 chunk +0 lines, -209 lines 0 comments Download
lib/src/source/path.dart View 1 chunk +0 lines, -134 lines 0 comments Download
test/build/allows_arbitrary_modes_test.dart View 1 chunk +0 lines, -58 lines 0 comments Download
test/build/compiles_dart_entrypoints_to_js_test.dart View 1 chunk +0 lines, -50 lines 0 comments Download
test/build/copies_browser_js_next_to_entrypoints_test.dart View 1 chunk +0 lines, -85 lines 0 comments Download
test/build/copies_non_dart_files_to_build_test.dart View 1 chunk +0 lines, -40 lines 0 comments Download
test/build/dart2js_finds_imports_across_packages_test.dart View 1 chunk +0 lines, -59 lines 0 comments Download
test/build/defaults_to_release_mode_test.dart View 1 chunk +0 lines, -58 lines 0 comments Download
test/build/handles_long_paths_test.dart View 1 chunk +0 lines, -72 lines 0 comments Download
test/build/ignores_non_entrypoint_dart_files_test.dart View 1 chunk +0 lines, -39 lines 0 comments Download
test/build/includes_assets_from_dependencies_test.dart View 1 chunk +0 lines, -55 lines 0 comments Download
test/build/includes_dart_files_in_debug_mode_test.dart View 1 chunk +0 lines, -41 lines 0 comments Download
test/build/reports_dart_parse_errors_test.dart View 1 chunk +0 lines, -50 lines 0 comments Download
test/build/with_no_web_directory_test.dart View 1 chunk +0 lines, -19 lines 0 comments Download
test/dependency_override_test.dart View 1 chunk +0 lines, -113 lines 0 comments Download
test/descriptor.dart View 1 chunk +0 lines, -170 lines 0 comments Download
test/descriptor/git.dart View 1 chunk +0 lines, -78 lines 0 comments Download
test/descriptor/tar.dart View 1 chunk +0 lines, -53 lines 0 comments Download
test/dev_dependency_test.dart View 1 chunk +0 lines, -109 lines 0 comments Download
test/directory_tree_test.dart View 1 chunk +0 lines, -146 lines 0 comments Download
test/error_group_test.dart View 1 chunk +0 lines, -446 lines 0 comments Download
test/get/broken_symlink_test.dart View 1 chunk +0 lines, -59 lines 0 comments Download
test/get/git/check_out_and_upgrade_test.dart View 1 chunk +0 lines, -60 lines 0 comments Download
test/get/git/check_out_branch_test.dart View 1 chunk +0 lines, -39 lines 0 comments Download
test/get/git/check_out_revision_test.dart View 1 chunk +0 lines, -39 lines 0 comments Download
test/get/git/check_out_test.dart View 1 chunk +0 lines, -37 lines 0 comments Download
test/get/git/check_out_transitive_test.dart View 1 chunk +0 lines, -51 lines 0 comments Download
test/get/git/check_out_twice_test.dart View 1 chunk +0 lines, -41 lines 0 comments Download
test/get/git/check_out_with_trailing_slash_test.dart View 1 chunk +0 lines, -41 lines 0 comments Download
test/get/git/dependency_name_match_pubspec_test.dart View 1 chunk +0 lines, -30 lines 0 comments Download
test/get/git/different_repo_name_test.dart View 1 chunk +0 lines, -35 lines 0 comments Download
test/get/git/lock_version_test.dart View 1 chunk +0 lines, -52 lines 0 comments Download
test/get/git/require_pubspec_name_test.dart View 1 chunk +0 lines, -26 lines 0 comments Download
test/get/git/require_pubspec_test.dart View 1 chunk +0 lines, -24 lines 0 comments Download
test/get/git/stay_locked_if_compatible_test.dart View 1 chunk +0 lines, -46 lines 0 comments Download
test/get/git/unlock_if_incompatible_test.dart View 1 chunk +0 lines, -46 lines 0 comments Download
test/get/hosted/avoid_network_requests_test.dart View 1 chunk +0 lines, -63 lines 0 comments Download
test/get/hosted/cached_pubspec_test.dart View 1 chunk +0 lines, -38 lines 0 comments Download
test/get/hosted/do_not_upgrade_on_removed_constraints_test.dart View 1 chunk +0 lines, -41 lines 0 comments Download
test/get/hosted/does_no_network_requests_when_possible_test.dart View 1 chunk +0 lines, -45 lines 0 comments Download
test/get/hosted/get_test.dart View 1 chunk +0 lines, -31 lines 0 comments Download
test/get/hosted/get_transitive_test.dart View 1 chunk +0 lines, -27 lines 0 comments Download
test/get/hosted/repair_cache_test.dart View 1 chunk +0 lines, -58 lines 0 comments Download
test/get/hosted/resolve_constraints_test.dart View 1 chunk +0 lines, -37 lines 0 comments Download
test/get/hosted/stay_locked_if_compatible_test.dart View 1 chunk +0 lines, -30 lines 0 comments Download
test/get/hosted/stay_locked_if_new_is_satisfied_test.dart View 1 chunk +0 lines, -48 lines 0 comments Download
test/get/hosted/stay_locked_test.dart View 1 chunk +0 lines, -38 lines 0 comments Download
test/get/hosted/unlock_if_incompatible_test.dart View 1 chunk +0 lines, -28 lines 0 comments Download
test/get/hosted/unlock_if_new_is_unsatisfied_test.dart View 1 chunk +0 lines, -52 lines 0 comments Download
test/get/path/absolute_path_test.dart View 1 chunk +0 lines, -43 lines 0 comments Download
test/get/path/absolute_symlink_test.dart View 1 chunk +0 lines, -41 lines 0 comments Download
test/get/path/no_pubspec_test.dart View 1 chunk +0 lines, -26 lines 0 comments Download
test/get/path/nonexistent_dir_test.dart View 1 chunk +0 lines, -23 lines 0 comments Download
test/get/path/path_is_file_test.dart View 1 chunk +0 lines, -30 lines 0 comments Download
test/get/path/relative_path_test.dart View 1 chunk +0 lines, -91 lines 0 comments Download
test/get/path/relative_symlink_test.dart View 1 chunk +0 lines, -50 lines 0 comments Download
test/get/path/shared_dependency_symlink_test.dart View 1 chunk +0 lines, -50 lines 0 comments Download
test/get/path/shared_dependency_test.dart View 1 chunk +0 lines, -119 lines 0 comments Download
test/get/relative_symlink_test.dart View 1 chunk +0 lines, -60 lines 0 comments Download
test/get/switch_source_test.dart View 1 chunk +0 lines, -31 lines 0 comments Download
test/hosted/fail_gracefully_on_missing_package_test.dart View 1 chunk +0 lines, -23 lines 0 comments Download
test/hosted/fail_gracefully_on_url_resolve_test.dart View 1 chunk +0 lines, -29 lines 0 comments Download
test/hosted/offline_test.dart View 1 chunk +0 lines, -67 lines 0 comments Download
test/hosted/remove_removed_dependency_test.dart View 1 chunk +0 lines, -39 lines 0 comments Download
test/hosted/remove_removed_transitive_dependency_test.dart View 1 chunk +0 lines, -54 lines 0 comments Download
test/hosted/version_negotiation_test.dart View 1 chunk +0 lines, -70 lines 0 comments Download
test/io_test.dart View 1 chunk +0 lines, -432 lines 0 comments Download
test/lish/archives_and_uploads_a_package_test.dart View 1 chunk +0 lines, -43 lines 0 comments Download
test/lish/cloud_storage_upload_doesnt_redirect_test.dart View 1 chunk +0 lines, -36 lines 0 comments Download
test/lish/cloud_storage_upload_provides_an_error_test.dart View 1 chunk +0 lines, -44 lines 0 comments Download
test/lish/force_cannot_be_combined_with_dry_run_test.dart View 1 chunk +0 lines, -20 lines 0 comments Download
test/lish/force_does_not_publish_if_there_are_errors_test.dart View 1 chunk +0 lines, -28 lines 0 comments Download
test/lish/force_publishes_if_tests_are_no_warnings_or_errors_test.dart View 1 chunk +0 lines, -37 lines 0 comments Download
test/lish/force_publishes_if_there_are_warnings_test.dart View 1 chunk +0 lines, -45 lines 0 comments Download
test/lish/package_creation_provides_a_malformed_error_test.dart View 1 chunk +0 lines, -38 lines 0 comments Download
test/lish/package_creation_provides_a_malformed_success_test.dart View 1 chunk +0 lines, -37 lines 0 comments Download
test/lish/package_creation_provides_an_error_test.dart View 1 chunk +0 lines, -39 lines 0 comments Download
test/lish/package_creation_provides_invalid_json_test.dart View 1 chunk +0 lines, -34 lines 0 comments Download
test/lish/package_validation_has_a_warning_and_continues_test.dart View 1 chunk +0 lines, -41 lines 0 comments Download
test/lish/package_validation_has_a_warning_and_is_canceled_test.dart View 1 chunk +0 lines, -28 lines 0 comments Download
test/lish/package_validation_has_an_error_test.dart View 1 chunk +0 lines, -28 lines 0 comments Download
test/lish/preview_package_validation_has_a_warning_test.dart View 1 chunk +0 lines, -30 lines 0 comments Download
test/lish/preview_package_validation_has_no_warnings_test.dart View 1 chunk +0 lines, -27 lines 0 comments Download
test/lish/upload_form_fields_has_a_non_string_value_test.dart View 1 chunk +0 lines, -34 lines 0 comments Download
test/lish/upload_form_fields_is_not_a_map_test.dart View 1 chunk +0 lines, -31 lines 0 comments Download
test/lish/upload_form_is_missing_fields_test.dart View 1 chunk +0 lines, -31 lines 0 comments Download
test/lish/upload_form_is_missing_url_test.dart View 1 chunk +0 lines, -37 lines 0 comments Download
test/lish/upload_form_provides_an_error_test.dart View 1 chunk +0 lines, -35 lines 0 comments Download
test/lish/upload_form_provides_invalid_json_test.dart View 1 chunk +0 lines, -31 lines 0 comments Download
test/lish/upload_form_url_is_not_a_string_test.dart View 1 chunk +0 lines, -38 lines 0 comments Download
test/lish/utils.dart View 1 chunk +0 lines, -53 lines 0 comments Download
test/list_package_dirs/ignores_updated_pubspec_test.dart View 1 chunk +0 lines, -49 lines 0 comments Download
test/list_package_dirs/includes_dev_dependencies_test.dart View 1 chunk +0 lines, -45 lines 0 comments Download
test/list_package_dirs/lists_dependency_directories_test.dart View 1 chunk +0 lines, -47 lines 0 comments Download

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b