Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(233)

Issue 36360043: code review 36360043: runtime: fix race detector when map keys/values are pas... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 7 months ago by khr
Modified:
11 years, 7 months ago
Reviewers:
dave, dvyukov
CC:
golang-dev, dave_cheney.net
Visibility:
Public.

Description

runtime: fix race detector when map keys/values are passed by pointer. Now that the map implementation is reading the keys and values from arbitrary memory (instead of from stack slots), it needs to tell the race detector when it does so. Fixes issue 6875.

Patch Set 1 #

Patch Set 2 : diff -r 8a51ecb97d05 https://khr%40golang.org@code.google.com/p/go/ #

Patch Set 3 : diff -r 8a51ecb97d05 https://khr%40golang.org@code.google.com/p/go/ #

Patch Set 4 : diff -r 48f6d30fb40d https://khr%40golang.org@code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -5 lines) Patch
M src/pkg/runtime/hashmap.c View 1 4 chunks +13 lines, -5 lines 0 comments Download

Messages

Total messages: 4
khr
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://khr%40golang.org@code.google.com/p/go/
11 years, 7 months ago (2013-12-03 01:31:21 UTC) #1
dave_cheney.net
On 2013/12/03 01:31:21, khr wrote: > Hello mailto:golang-dev@googlegroups.com, > > I'd like you to review ...
11 years, 7 months ago (2013-12-03 01:34:18 UTC) #2
khr
*** Submitted as https://code.google.com/p/go/source/detail?r=6ec0276dad0e *** runtime: fix race detector when map keys/values are passed by ...
11 years, 7 months ago (2013-12-03 02:03:27 UTC) #3
dvyukov
11 years, 7 months ago (2013-12-03 06:51:31 UTC) #4
Message was sent while issue was closed.
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b