Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1059)

Issue 36240043: Adds pending and dying statuses to the inspector

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 3 months ago by jeff.pihach
Modified:
10 years, 3 months ago
Reviewers:
matthew.scott, mp+197441
Visibility:
Public.

Description

Adds pending and dying statuses to the inspector A service in various states of pending are now properly represented in the inspector. Dying services are now left on the canvas with their inspectors until the service is entirely destroyed from Juju. https://code.launchpad.net/~hatch/juju-gui/parse-pending-types/+merge/197441 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 1

Patch Set 2 : Adds pending and dying statuses to the inspector #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -71 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M app/models/handlers.js View 1 chunk +4 lines, -1 line 0 comments Download
M app/models/models.js View 4 chunks +16 lines, -17 lines 0 comments Download
M app/store/env/simulator.js View 1 chunk +2 lines, -12 lines 0 comments Download
M app/views/environment.js View 1 chunk +2 lines, -23 lines 0 comments Download
M app/views/inspector.js View 1 chunk +1 line, -1 line 0 comments Download
M app/views/utils.js View 2 chunks +15 lines, -7 lines 0 comments Download
M app/views/viewlets/service-overview.js View 2 chunks +6 lines, -4 lines 0 comments Download
M test/test_model.js View 2 chunks +5 lines, -5 lines 0 comments Download
M test/test_service_module.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
jeff.pihach
Please take a look.
10 years, 3 months ago (2013-12-02 21:33:37 UTC) #1
matthew.scott
LGTM, QA okay, one question, feel free to say no! Thanks. https://codereview.appspot.com/36240043/diff/1/app/models/models.js File app/models/models.js (right): ...
10 years, 3 months ago (2013-12-02 23:55:14 UTC) #2
jeff.pihach
10 years, 3 months ago (2013-12-03 13:47:53 UTC) #3
*** Submitted:

Adds pending and dying statuses to the inspector

A service in various states of pending are now properly represented in the
inspector.

Dying services are now left on the canvas with their inspectors until the
service
is entirely destroyed from Juju.

R=matthew.scott
CC=
https://codereview.appspot.com/36240043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b