Issue 3607043: Change sunspider tests to be ES5 strict compliant and add them to the playground

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3607043: Change sunspider tests to be ES5 strict compliant and add them to the playground (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 3 months ago by Jasvir

Modified:
15 years, 3 months ago

Reviewers:
metaweta

CC:
google-caja-discuss_googlegroups.com

Base URL:
http://google-caja.googlecode.com/svn/trunk/

Visibility:
Public.

Description

Makes sunspider tests ES5 strict compliant (these need to be pushed upstream) Adds benchmarks to the playground Addresses playground issue 1304 when URL is blank or malformed Applies UMP header on cajoling service responses @4336

Patch Set 1 #

Patch Set 2 : Change sunspider tests to be ES5 strict compliant and add them to the playground #

Total comments: 1

Created: 15 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6979 lines, -66 lines)			Patch
M	build.xml	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/com/google/caja/demos/playground/client/Playground.java	View		3 chunks	+21 lines, -15 lines	0 comments	Download
M	src/com/google/caja/demos/playground/client/PlaygroundService.java	View		2 chunks	+3 lines, -2 lines	0 comments	Download
M	src/com/google/caja/demos/playground/client/PlaygroundServiceAsync.java	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/com/google/caja/demos/playground/client/policy.js	View		1 chunk	+12 lines, -0 lines	0 comments	Download
M	src/com/google/caja/demos/playground/client/ui/Example.java	View		2 chunks	+42 lines, -1 line	0 comments	Download
M	src/com/google/caja/demos/playground/server/GWTCajolingServiceImpl.java	View		4 chunks	+21 lines, -8 lines	0 comments	Download
M	src/com/google/caja/demos/playground/taming.js	View		1 chunk	+1 line, -1 line	1 comment	Download
M	src/com/google/caja/service/CajaArguments.java	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/com/google/caja/service/CajolingService.java	View		4 chunks	+26 lines, -8 lines	0 comments	Download
M	src/com/google/caja/service/CajolingServlet.java	View	1	4 chunks	+5 lines, -0 lines	0 comments	Download
M	tests/com/google/caja/demos/playground/GWTCajolingServiceImplTest.java	View		1 chunk	+2 lines, -2 lines	0 comments	Download
A	third_party/js/sunspider-benchmark/3d-cube.html	View		1 chunk	+387 lines, -0 lines	0 comments	Download
M	third_party/js/sunspider-benchmark/3d-cube.js	View		1 chunk	+1 line, -1 line	0 comments	Download
A	third_party/js/sunspider-benchmark/3d-morph.html	View		1 chunk	+104 lines, -0 lines	0 comments	Download
M	third_party/js/sunspider-benchmark/3d-morph.js	View		1 chunk	+1 line, -1 line	0 comments	Download
A	third_party/js/sunspider-benchmark/3d-raytrace.html	View		1 chunk	+491 lines, -0 lines	0 comments	Download
M	third_party/js/sunspider-benchmark/3d-raytrace.js	View		5 chunks	+8 lines, -8 lines	0 comments	Download
A	third_party/js/sunspider-benchmark/access-binary-trees.html	View		1 chunk	+100 lines, -0 lines	0 comments	Download
A	third_party/js/sunspider-benchmark/access-fannkuch.html	View		1 chunk	+116 lines, -0 lines	0 comments	Download
A	third_party/js/sunspider-benchmark/access-nbody.html	View		1 chunk	+219 lines, -0 lines	0 comments	Download
A	third_party/js/sunspider-benchmark/access-nsieve.html	View		1 chunk	+88 lines, -0 lines	0 comments	Download
A	third_party/js/sunspider-benchmark/bitops-3bit-bits-in-byte.html	View		1 chunk	+82 lines, -0 lines	0 comments	Download
A	third_party/js/sunspider-benchmark/bitops-bits-in-byte.html	View		1 chunk	+71 lines, -0 lines	0 comments	Download
A	third_party/js/sunspider-benchmark/bitops-bitwise-and.html	View		1 chunk	+78 lines, -0 lines	0 comments	Download
M	third_party/js/sunspider-benchmark/bitops-bitwise-and.js	View		1 chunk	+1 line, -1 line	0 comments	Download
A	third_party/js/sunspider-benchmark/bitops-nsieve-bits.html	View		1 chunk	+82 lines, -0 lines	0 comments	Download
A	third_party/js/sunspider-benchmark/controlflow-recursive.html	View		1 chunk	+75 lines, -0 lines	0 comments	Download
A	third_party/js/sunspider-benchmark/crypto-aes.html	View		1 chunk	+472 lines, -0 lines	0 comments	Download
A	third_party/js/sunspider-benchmark/crypto-md5.html	View		1 chunk	+336 lines, -0 lines	0 comments	Download
A	third_party/js/sunspider-benchmark/crypto-sha1.html	View		1 chunk	+274 lines, -0 lines	0 comments	Download
A	third_party/js/sunspider-benchmark/date-format-tofte.html	View		1 chunk	+349 lines, -0 lines	0 comments	Download
M	third_party/js/sunspider-benchmark/date-format-tofte.js	View		3 chunks	+6 lines, -6 lines	0 comments	Download
A	third_party/js/sunspider-benchmark/date-format-xparb.html	View		1 chunk	+467 lines, -0 lines	0 comments	Download
M	third_party/js/sunspider-benchmark/date-format-xparb.js	View		1 chunk	+1 line, -1 line	0 comments	Download
A	third_party/js/sunspider-benchmark/math-cordic.html	View		1 chunk	+145 lines, -0 lines	0 comments	Download
A	third_party/js/sunspider-benchmark/math-partial-sums.html	View		1 chunk	+85 lines, -0 lines	0 comments	Download
M	third_party/js/sunspider-benchmark/math-partial-sums.js	View		1 chunk	+4 lines, -2 lines	0 comments	Download
A	third_party/js/sunspider-benchmark/math-spectral-norm.html	View		1 chunk	+101 lines, -0 lines	0 comments	Download
A	third_party/js/sunspider-benchmark/regexp-dna.html	View		1 chunk	+1762 lines, -0 lines	0 comments	Download
M	third_party/js/sunspider-benchmark/regexp-dna.js	View		1 chunk	+2 lines, -2 lines	0 comments	Download
A	third_party/js/sunspider-benchmark/string-base64.html	View		1 chunk	+185 lines, -0 lines	0 comments	Download
A	third_party/js/sunspider-benchmark/string-fasta.html	View		1 chunk	+135 lines, -0 lines	0 comments	Download
A	third_party/js/sunspider-benchmark/string-tagcloud.html	View		1 chunk	+315 lines, -0 lines	0 comments	Download
A	third_party/js/sunspider-benchmark/string-unpack-code.html	View		1 chunk	+117 lines, -0 lines	0 comments	Download
A	third_party/js/sunspider-benchmark/string-validate-input.html	View		1 chunk	+139 lines, -0 lines	0 comments	Download
M	third_party/js/sunspider-benchmark/string-validate-input.js	View		2 chunks	+5 lines, -5 lines	0 comments	Download
A	third_party/js/sunspider-benchmark/sunspider-record-result.js	View		1 chunk	+31 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

metaweta

15 years, 3 months ago (2010-12-13 00:26:28 UTC) #2

LGTM mod cruft

http://codereview.appspot.com/3607043/diff/3001/src/com/google/caja/demos/pla...
File src/com/google/caja/demos/playground/taming.js (right):

http://codereview.appspot.com/3607043/diff/3001/src/com/google/caja/demos/pla...
src/com/google/caja/demos/playground/taming.js:78: currentFrame.src =
"http://localhost:8080/es53.html?rnd=" + Math.floor(Math.random() * 10000);
localhost cruft

Expand All Messages | Collapse All Messages