Issue 36060043: Background panning (adopted from Huw)

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 36060043: Background panning (adopted from Huw)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 4 months ago by matthew.scott

Modified:
10 years, 4 months ago

Reviewers:
mp+197418, jeff.pihach

Visibility:
Public.

Description

Background panning (adopted from Huw) Fixed the background so that it moves when you pan the canvas. This has been bothering me for a while. Works for me accross browsers. https://code.launchpad.net/~makyo/juju-gui/background-drag/+merge/197418 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 1

Patch Set 2 : Background panning (adopted from Huw) #

Patch Set 3 : Background panning (adopted from Huw) #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -1 line)			Patch
A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	app/views/topology/panzoom.js	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
M	app/views/topology/topology.js	View	1	2 chunks	+7 lines, -0 lines	0 comments	Download
M	test/test_panzoom.js	View		2 chunks	+10 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

jeff.pihach

LGTM with trivial, thanks. https://codereview.appspot.com/36060043/diff/1/app/views/topology/panzoom.js File app/views/topology/panzoom.js (right): https://codereview.appspot.com/36060043/diff/1/app/views/topology/panzoom.js#newcode262 app/views/topology/panzoom.js:262: var canvas = Y.one('.topology-canvas'); Can ...

10 years, 4 months ago (2013-12-02 17:05:28 UTC) #2

matthew.scott

10 years, 4 months ago (2013-12-02 17:26:39 UTC) #3

*** Submitted:

Background panning (adopted from Huw)

Fixed the background so that it moves when you pan the canvas. This has been
bothering me for a while. Works for me accross browsers.

R=jeff.pihach
CC=
https://codereview.appspot.com/36060043

Expand All Messages | Collapse All Messages