10 years, 2 months ago
(2014-01-08 12:58:08 UTC)
#11
On 2013/12/29 17:44:55, aram wrote:
> Hello mailto:golang-codereviews@googlegroups.com, mailto:dave@cheney.net,
mailto:jsing@google.com
> (cc: mailto:golang-codereviews@googlegroups.com),
>
> Please take another look.
It would seem that the branch/revision history is still not visible.
> It would seem that the branch/revision history is still not visible. Everything should show ...
10 years, 2 months ago
(2014-01-09 15:07:16 UTC)
#12
> It would seem that the branch/revision history is still not visible.
Everything should show up with the exception of exec_solaris.go. I can't make
that work. I can't explain it, other files, like types_solaris.go show up just
fine. Maybe it's another rietveld bug.
LGTM with one minor comment. https://codereview.appspot.com/36000043/diff/440001/src/pkg/syscall/types_solaris.go File src/pkg/syscall/types_solaris.go (right): https://codereview.appspot.com/36000043/diff/440001/src/pkg/syscall/types_solaris.go#newcode1 src/pkg/syscall/types_solaris.go:1: // Copyright 2009 The ...
10 years, 2 months ago
(2014-01-15 01:04:57 UTC)
#14
https://codereview.appspot.com/36000043/diff/440001/src/pkg/syscall/types_solaris.go File src/pkg/syscall/types_solaris.go (right): https://codereview.appspot.com/36000043/diff/440001/src/pkg/syscall/types_solaris.go#newcode1 src/pkg/syscall/types_solaris.go:1: // Copyright 2009 The Go Authors. All rights reserved. ...
10 years, 2 months ago
(2014-01-16 13:49:37 UTC)
#17
Looking good, few things minor things to clean up. https://codereview.appspot.com/36000043/diff/480001/src/pkg/syscall/exec_solaris.go File src/pkg/syscall/exec_solaris.go (right): https://codereview.appspot.com/36000043/diff/480001/src/pkg/syscall/exec_solaris.go#newcode1 src/pkg/syscall/exec_solaris.go:1: ...
10 years, 2 months ago
(2014-01-17 12:00:10 UTC)
#18
https://codereview.appspot.com/36000043/diff/480001/src/pkg/syscall/exec_solaris.go File src/pkg/syscall/exec_solaris.go (right): https://codereview.appspot.com/36000043/diff/480001/src/pkg/syscall/exec_solaris.go#newcode1 src/pkg/syscall/exec_solaris.go:1: // Copyright 2011 The Go Authors. All rights reserved. ...
10 years, 2 months ago
(2014-01-17 16:01:15 UTC)
#19
10 years, 1 month ago
(2014-02-12 04:04:51 UTC)
#21
On 2014/01/17 16:01:43, aram wrote:
> Hello mailto:golang-codereviews@googlegroups.com, mailto:dave@cheney.net,
mailto:jsing@google.com,
> mailto:gobot@golang.org (cc: mailto:golang-codereviews@googlegroups.com),
>
> Please take another look.
Would it be possible to get another pass of this CL. With the solaris linker
changes that Minux is landing we're at the point that the build bot can validate
that this CL at least builds.
https://codereview.appspot.com/36000043/diff/800001/src/pkg/syscall/mkerrors.sh File src/pkg/syscall/mkerrors.sh (right): https://codereview.appspot.com/36000043/diff/800001/src/pkg/syscall/mkerrors.sh#newcode325 src/pkg/syscall/mkerrors.sh:325: echo -E " This is awful. It apparently has ...
10 years, 1 month ago
(2014-02-24 17:13:58 UTC)
#29
Issue 36000043: code review 36000043: syscall: add support for GOOS=solaris
Created 10 years, 3 months ago by aram
Modified 10 years, 1 month ago
Reviewers:
Base URL:
Comments: 51