Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1565)

Issue 36000043: code review 36000043: syscall: add support for GOOS=solaris

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 3 months ago by aram
Modified:
10 years, 1 month ago
Reviewers:
minux1, dfc, jsing
CC:
golang-codereviews, dfc, jsing, gobot, minux1, rsc, iant, mikio
Visibility:
Public.

Description

syscall: add support for GOOS=solaris These are only the new files, autogenerated files are in a different CL to keep the size down.

Patch Set 1 #

Patch Set 2 : diff -r bddf2a72f5e1 https://code.google.com/p/go #

Patch Set 3 : diff -r bddf2a72f5e1 https://code.google.com/p/go #

Patch Set 4 : diff -r bddf2a72f5e1 https://code.google.com/p/go #

Patch Set 5 : diff -r bddf2a72f5e1 https://code.google.com/p/go #

Patch Set 6 : diff -r 6835745cc243 https://code.google.com/p/go #

Patch Set 7 : diff -r 6835745cc243 https://code.google.com/p/go #

Patch Set 8 : diff -r 6835745cc243 https://code.google.com/p/go #

Patch Set 9 : diff -r 17615253b9e8 https://code.google.com/p/go #

Patch Set 10 : diff -r 17615253b9e8 https://code.google.com/p/go #

Total comments: 9

Patch Set 11 : diff -r 17615253b9e8 https://code.google.com/p/go #

Patch Set 12 : diff -r 17615253b9e8 https://code.google.com/p/go #

Patch Set 13 : diff -r d45af824172f https://code.google.com/p/go #

Patch Set 14 : diff -r c4b7c0824984 https://code.google.com/p/go #

Patch Set 15 : diff -r c4b7c0824984 https://code.google.com/p/go #

Patch Set 16 : diff -r c4b7c0824984 https://code.google.com/p/go #

Patch Set 17 : diff -r c4b7c0824984 https://code.google.com/p/go #

Patch Set 18 : diff -r 1e52bf0c539c https://code.google.com/p/go #

Patch Set 19 : diff -r 1e52bf0c539c https://code.google.com/p/go #

Patch Set 20 : diff -r 884801fb67af https://code.google.com/p/go #

Patch Set 21 : diff -r 884801fb67af https://code.google.com/p/go #

Patch Set 22 : diff -r 884801fb67af https://code.google.com/p/go #

Patch Set 23 : diff -r 884801fb67af https://code.google.com/p/go #

Patch Set 24 : diff -r 884801fb67af https://code.google.com/p/go #

Patch Set 25 : diff -r 99a1e180eda3 https://code.google.com/p/go #

Total comments: 2

Patch Set 26 : diff -r ff8459d06e3f https://code.google.com/p/go #

Patch Set 27 : diff -r ff8459d06e3f https://code.google.com/p/go #

Total comments: 14

Patch Set 28 : diff -r 322f646feecb https://code.google.com/p/go #

Patch Set 29 : diff -r 322f646feecb https://code.google.com/p/go #

Patch Set 30 : diff -r 322f646feecb https://code.google.com/p/go #

Patch Set 31 : diff -r 322f646feecb https://code.google.com/p/go #

Patch Set 32 : diff -r 322f646feecb https://code.google.com/p/go #

Patch Set 33 : diff -r 322f646feecb https://code.google.com/p/go #

Patch Set 34 : diff -r 322f646feecb https://code.google.com/p/go #

Patch Set 35 : diff -r 322f646feecb https://code.google.com/p/go #

Patch Set 36 : diff -r e2dd08f26402 https://code.google.com/p/go #

Patch Set 37 : diff -r e2dd08f26402 https://code.google.com/p/go #

Patch Set 38 : diff -r e2dd08f26402 https://code.google.com/p/go #

Patch Set 39 : diff -r 70499e5fbe5b https://code.google.com/p/go #

Patch Set 40 : diff -r 70499e5fbe5b https://code.google.com/p/go #

Patch Set 41 : diff -r 70499e5fbe5b https://code.google.com/p/go #

Patch Set 42 : diff -r 70499e5fbe5b https://code.google.com/p/go #

Total comments: 11

Patch Set 43 : diff -r 27a1bda549a2 https://code.google.com/p/go #

Patch Set 44 : diff -r 27a1bda549a2 https://code.google.com/p/go #

Total comments: 15

Patch Set 45 : diff -r c33b9dafa027 https://code.google.com/p/go #

Patch Set 46 : diff -r c33b9dafa027 https://code.google.com/p/go #

Patch Set 47 : diff -r c33b9dafa027 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+599 lines, -681 lines) Patch
A src/pkg/syscall/asm_solaris_amd64.s View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 1 chunk +7 lines, -0 lines 0 comments Download
M src/pkg/syscall/env_unix.go View 1 2 3 4 5 6 7 8 9 10 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/syscall/exec_solaris.go View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 36 39 40 13 chunks +43 lines, -47 lines 0 comments Download
M src/pkg/syscall/exec_unix.go View 1 2 3 4 5 6 7 8 9 10 43 44 45 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/syscall/mkall.sh View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 1 chunk +6 lines, -0 lines 0 comments Download
M src/pkg/syscall/mkerrors.sh View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 3 chunks +24 lines, -7 lines 0 comments Download
M src/pkg/syscall/mksyscall_solaris.pl View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 7 chunks +95 lines, -121 lines 0 comments Download
M src/pkg/syscall/so_solaris.go View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 8 chunks +98 lines, -117 lines 0 comments Download
M src/pkg/syscall/sockcmsg_unix.go View 1 2 3 4 5 6 7 8 9 10 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/syscall/syscall_solaris.go View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 9 chunks +300 lines, -313 lines 0 comments Download
M src/pkg/syscall/syscall_solaris_amd64.go View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 2 chunks +2 lines, -23 lines 0 comments Download
M src/pkg/syscall/syscall_unix.go View 1 2 3 4 5 6 7 8 9 10 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/syscall/syscall_unix_test.go View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 2 chunks +6 lines, -2 lines 0 comments Download
M src/pkg/syscall/types_solaris.go View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 10 chunks +14 lines, -47 lines 0 comments Download

Messages

Total messages: 36
aram
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
10 years, 3 months ago (2013-12-10 20:40:13 UTC) #1
dfc
LGTM with minor comments. Please wait for rsc. https://codereview.appspot.com/36000043/diff/180001/src/pkg/syscall/mkerrors.sh File src/pkg/syscall/mkerrors.sh (right): https://codereview.appspot.com/36000043/diff/180001/src/pkg/syscall/mkerrors.sh#newcode379 src/pkg/syscall/mkerrors.sh:379: printf("\t%d: ...
10 years, 3 months ago (2013-12-11 00:35:30 UTC) #2
jsing
I haven't checked the remaining files - if they have been derived from an existing ...
10 years, 3 months ago (2013-12-11 14:20:25 UTC) #3
aram
Files are actually hg cp'd, it's my script that generates CLs from my private mercurial ...
10 years, 3 months ago (2013-12-11 14:21:59 UTC) #4
aram
https://codereview.appspot.com/36000043/diff/180001/src/pkg/syscall/mkerrors.sh File src/pkg/syscall/mkerrors.sh (right): https://codereview.appspot.com/36000043/diff/180001/src/pkg/syscall/mkerrors.sh#newcode379 src/pkg/syscall/mkerrors.sh:379: printf("\t%d: \"%s\",\\n", e, buf); On 2013/12/11 00:35:31, dfc wrote: ...
10 years, 3 months ago (2013-12-11 21:25:58 UTC) #5
aram
Hello golang-dev@googlegroups.com, dave@cheney.net, jsing@google.com (cc: golang-dev@googlegroups.com), Please take another look.
10 years, 3 months ago (2013-12-11 21:29:02 UTC) #6
gobot
Replacing golang-dev with golang-codereviews.
10 years, 3 months ago (2013-12-20 16:26:14 UTC) #7
gobot
Replacing golang-dev with golang-codereviews.
10 years, 3 months ago (2013-12-20 16:26:14 UTC) #8
aram
Hello golang-codereviews@googlegroups.com, dave@cheney.net, jsing@google.com (cc: golang-codereviews@googlegroups.com), Please take another look.
10 years, 3 months ago (2013-12-21 21:48:33 UTC) #9
aram
Hello golang-codereviews@googlegroups.com, dave@cheney.net, jsing@google.com (cc: golang-codereviews@googlegroups.com), Please take another look.
10 years, 3 months ago (2013-12-29 17:44:55 UTC) #10
jsing
On 2013/12/29 17:44:55, aram wrote: > Hello mailto:golang-codereviews@googlegroups.com, mailto:dave@cheney.net, mailto:jsing@google.com > (cc: mailto:golang-codereviews@googlegroups.com), > > ...
10 years, 2 months ago (2014-01-08 12:58:08 UTC) #11
aram
> It would seem that the branch/revision history is still not visible. Everything should show ...
10 years, 2 months ago (2014-01-09 15:07:16 UTC) #12
aram
Hello golang-codereviews@googlegroups.com, dave@cheney.net, jsing@google.com (cc: golang-codereviews@googlegroups.com), Please take another look.
10 years, 2 months ago (2014-01-09 15:10:29 UTC) #13
dfc
LGTM with one minor comment. https://codereview.appspot.com/36000043/diff/440001/src/pkg/syscall/types_solaris.go File src/pkg/syscall/types_solaris.go (right): https://codereview.appspot.com/36000043/diff/440001/src/pkg/syscall/types_solaris.go#newcode1 src/pkg/syscall/types_solaris.go:1: // Copyright 2009 The ...
10 years, 2 months ago (2014-01-15 01:04:57 UTC) #14
gobot
R=jsing@google.com (assigned by dave@cheney.net)
10 years, 2 months ago (2014-01-15 01:06:13 UTC) #15
aram
Hello golang-codereviews@googlegroups.com, dave@cheney.net, jsing@google.com, gobot@golang.org (cc: golang-codereviews@googlegroups.com), Please take another look.
10 years, 2 months ago (2014-01-16 13:49:07 UTC) #16
aram
https://codereview.appspot.com/36000043/diff/440001/src/pkg/syscall/types_solaris.go File src/pkg/syscall/types_solaris.go (right): https://codereview.appspot.com/36000043/diff/440001/src/pkg/syscall/types_solaris.go#newcode1 src/pkg/syscall/types_solaris.go:1: // Copyright 2009 The Go Authors. All rights reserved. ...
10 years, 2 months ago (2014-01-16 13:49:37 UTC) #17
jsing
Looking good, few things minor things to clean up. https://codereview.appspot.com/36000043/diff/480001/src/pkg/syscall/exec_solaris.go File src/pkg/syscall/exec_solaris.go (right): https://codereview.appspot.com/36000043/diff/480001/src/pkg/syscall/exec_solaris.go#newcode1 src/pkg/syscall/exec_solaris.go:1: ...
10 years, 2 months ago (2014-01-17 12:00:10 UTC) #18
aram
https://codereview.appspot.com/36000043/diff/480001/src/pkg/syscall/exec_solaris.go File src/pkg/syscall/exec_solaris.go (right): https://codereview.appspot.com/36000043/diff/480001/src/pkg/syscall/exec_solaris.go#newcode1 src/pkg/syscall/exec_solaris.go:1: // Copyright 2011 The Go Authors. All rights reserved. ...
10 years, 2 months ago (2014-01-17 16:01:15 UTC) #19
aram
Hello golang-codereviews@googlegroups.com, dave@cheney.net, jsing@google.com, gobot@golang.org (cc: golang-codereviews@googlegroups.com), Please take another look.
10 years, 2 months ago (2014-01-17 16:01:43 UTC) #20
dfc
On 2014/01/17 16:01:43, aram wrote: > Hello mailto:golang-codereviews@googlegroups.com, mailto:dave@cheney.net, mailto:jsing@google.com, > mailto:gobot@golang.org (cc: mailto:golang-codereviews@googlegroups.com), > ...
10 years, 1 month ago (2014-02-12 04:04:51 UTC) #21
aram
Hello golang-codereviews@googlegroups.com, dave@cheney.net, jsing@google.com, gobot@golang.org (cc: golang-codereviews@googlegroups.com), Please take another look.
10 years, 1 month ago (2014-02-12 11:31:28 UTC) #22
aram
Hello golang-codereviews@googlegroups.com, dave@cheney.net, jsing@google.com, gobot@golang.org (cc: golang-codereviews@googlegroups.com), Please take another look.
10 years, 1 month ago (2014-02-22 17:19:02 UTC) #23
aram
Hello golang-codereviews@googlegroups.com, dave@cheney.net, jsing@google.com, gobot@golang.org (cc: golang-codereviews@googlegroups.com), Please take another look.
10 years, 1 month ago (2014-02-22 17:22:44 UTC) #24
aram
Gentle ping.
10 years, 1 month ago (2014-02-22 17:23:09 UTC) #25
minux1
this one might need some further input on the exported API from others. R: +rsc, ...
10 years, 1 month ago (2014-02-22 22:07:14 UTC) #26
aram
I unexported the syscall dlopen/NewSO stuff. https://codereview.appspot.com/36000043/diff/760001/src/pkg/syscall/asm_solaris_amd64.s File src/pkg/syscall/asm_solaris_amd64.s (right): https://codereview.appspot.com/36000043/diff/760001/src/pkg/syscall/asm_solaris_amd64.s#newcode1 src/pkg/syscall/asm_solaris_amd64.s:1: // Copyright 2013 ...
10 years, 1 month ago (2014-02-24 15:43:32 UTC) #27
aram
Hello golang-codereviews@googlegroups.com, dave@cheney.net, jsing@google.com, gobot@golang.org, minux.ma@gmail.com, rsc@golang.org, iant@golang.org (cc: golang-codereviews@googlegroups.com), Please take another look.
10 years, 1 month ago (2014-02-24 15:44:57 UTC) #28
rsc
https://codereview.appspot.com/36000043/diff/800001/src/pkg/syscall/mkerrors.sh File src/pkg/syscall/mkerrors.sh (right): https://codereview.appspot.com/36000043/diff/800001/src/pkg/syscall/mkerrors.sh#newcode325 src/pkg/syscall/mkerrors.sh:325: echo -E " This is awful. It apparently has ...
10 years, 1 month ago (2014-02-24 17:13:58 UTC) #29
jsing
https://codereview.appspot.com/36000043/diff/800001/src/pkg/syscall/so_solaris.go File src/pkg/syscall/so_solaris.go (right): https://codereview.appspot.com/36000043/diff/800001/src/pkg/syscall/so_solaris.go#newcode13 src/pkg/syscall/so_solaris.go:13: // soError describes reasons for shared libraries load failures. ...
10 years, 1 month ago (2014-02-24 17:36:29 UTC) #30
aram
https://codereview.appspot.com/36000043/diff/800001/src/pkg/syscall/mkerrors.sh File src/pkg/syscall/mkerrors.sh (right): https://codereview.appspot.com/36000043/diff/800001/src/pkg/syscall/mkerrors.sh#newcode325 src/pkg/syscall/mkerrors.sh:325: echo -E " On 2014/02/24 17:13:59, rsc wrote: > ...
10 years, 1 month ago (2014-02-24 21:18:36 UTC) #31
aram
Hello golang-codereviews@googlegroups.com, dave@cheney.net, jsing@google.com, gobot@golang.org, minux.ma@gmail.com, rsc@golang.org, iant@golang.org (cc: golang-codereviews@googlegroups.com), Please take another look.
10 years, 1 month ago (2014-02-24 21:19:25 UTC) #32
mikio
and now, this is the last fragment.
10 years, 1 month ago (2014-02-25 08:24:09 UTC) #33
minux1
On Feb 25, 2014 3:24 AM, "Mikio Hara" <mikioh.mikioh@gmail.com> wrote: > and now, this is ...
10 years, 1 month ago (2014-02-25 09:29:06 UTC) #34
jsing
LGTM
10 years, 1 month ago (2014-02-25 10:11:50 UTC) #35
jsing
10 years, 1 month ago (2014-02-25 10:14:11 UTC) #36
*** Submitted as https://code.google.com/p/go/source/detail?r=da7776a7f91c ***

syscall: add support for GOOS=solaris

These are only the new files, autogenerated files are in a
different CL to keep the size down.

LGTM=dave, minux.ma, jsing
R=golang-codereviews, dave, jsing, gobot, minux.ma, rsc, iant, mikioh.mikioh
CC=golang-codereviews
https://codereview.appspot.com/36000043

Committer: Joel Sing <jsing@google.com>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b