Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3012)

Issue 35990043: code review 35990043: runtime: add support for GOOS=solaris

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years ago by aram
Modified:
5 months ago
CC:
brainman, dave_cheney.net, jsing, gobot, golang-codereviews
Visibility:
Public.

Description

runtime: add support for GOOS=solaris

Patch Set 1 #

Patch Set 2 : diff -r bddf2a72f5e1 https://code.google.com/p/go #

Patch Set 3 : diff -r bddf2a72f5e1 https://code.google.com/p/go #

Patch Set 4 : diff -r bddf2a72f5e1 https://code.google.com/p/go #

Patch Set 5 : diff -r bddf2a72f5e1 https://code.google.com/p/go #

Patch Set 6 : diff -r 6835745cc243 https://code.google.com/p/go #

Patch Set 7 : diff -r 6835745cc243 https://code.google.com/p/go #

Patch Set 8 : diff -r 6835745cc243 https://code.google.com/p/go #

Patch Set 9 : diff -r 6835745cc243 https://code.google.com/p/go #

Patch Set 10 : diff -r 17615253b9e8 https://code.google.com/p/go #

Patch Set 11 : diff -r 17615253b9e8 https://code.google.com/p/go #

Total comments: 5

Patch Set 12 : diff -r 17615253b9e8 https://code.google.com/p/go #

Patch Set 13 : diff -r d45af824172f https://code.google.com/p/go #

Patch Set 14 : diff -r c4b7c0824984 https://code.google.com/p/go #

Patch Set 15 : diff -r c4b7c0824984 https://code.google.com/p/go #

Patch Set 16 : diff -r c4b7c0824984 https://code.google.com/p/go #

Patch Set 17 : diff -r 1e52bf0c539c https://code.google.com/p/go #

Patch Set 18 : diff -r 1e52bf0c539c https://code.google.com/p/go #

Total comments: 23

Patch Set 19 : diff -r 884801fb67af https://code.google.com/p/go #

Patch Set 20 : diff -r 884801fb67af https://code.google.com/p/go #

Total comments: 16

Patch Set 21 : diff -r 99a1e180eda3 https://code.google.com/p/go #

Patch Set 22 : diff -r 99a1e180eda3 https://code.google.com/p/go #

Total comments: 10

Patch Set 23 : diff -r ff8459d06e3f https://code.google.com/p/go #

Patch Set 24 : diff -r ff8459d06e3f https://code.google.com/p/go #

Total comments: 5
Unified diffs Side-by-side diffs Delta from patch set Stats (+1705 lines, -188 lines) Patch
M src/cmd/dist/buildruntime.c View 1 2 3 3 chunks +8 lines, -3 lines 0 comments Download
M src/pkg/runtime/arch_amd64.h View 1 2 3 4 5 6 7 8 1 chunk +4 lines, -0 lines 0 comments Download
M src/pkg/runtime/asm_amd64.s View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 2 chunks +10 lines, -1 line 0 comments Download
M src/pkg/runtime/cgocall.c View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/runtime/defs_solaris.go View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 5 chunks +54 lines, -29 lines 0 comments Download
A src/pkg/runtime/defs_solaris_amd64.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +254 lines, -0 lines 0 comments Download
A src/pkg/runtime/defs_solaris_amd64.go View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 1 chunk +48 lines, -0 lines 0 comments Download
M src/pkg/runtime/env_posix.c View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/runtime/lfstack.c View 1 2 3 1 chunk +14 lines, -0 lines 4 comments Download
M src/pkg/runtime/lock_sema.c View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/runtime/mem_solaris.c View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 1 chunk +2 lines, -1 line 0 comments Download
M src/pkg/runtime/netpoll.goc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 3 chunks +13 lines, -1 line 0 comments Download
A src/pkg/runtime/os_solaris.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 1 chunk +51 lines, -0 lines 0 comments Download
M src/pkg/runtime/os_solaris.c View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 6 chunks +403 lines, -120 lines 0 comments Download
M src/pkg/runtime/os_windows.c View 1 1 chunk +5 lines, -5 lines 0 comments Download
M src/pkg/runtime/proc.c View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 1 chunk +2 lines, -2 lines 0 comments Download
A src/pkg/runtime/rt0_solaris_amd64.s View 1 2 3 1 chunk +18 lines, -0 lines 0 comments Download
M src/pkg/runtime/runtime.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 5 chunks +29 lines, -3 lines 0 comments Download
M src/pkg/runtime/runtime.c View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M src/pkg/runtime/signal_amd64.c View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A src/pkg/runtime/signal_solaris_amd64.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +31 lines, -0 lines 0 comments Download
M src/pkg/runtime/signal_unix.c View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A src/pkg/runtime/signals_solaris.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 1 chunk +94 lines, -0 lines 0 comments Download
A src/pkg/runtime/sys_solaris_amd64.s View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 1 chunk +267 lines, -0 lines 1 comment Download
M src/pkg/runtime/sys_windows_386.s View 1 1 chunk +6 lines, -6 lines 0 comments Download
M src/pkg/runtime/sys_windows_amd64.s View 1 2 chunks +5 lines, -5 lines 0 comments Download
A src/pkg/runtime/syscall_solaris.goc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 1 chunk +374 lines, -0 lines 0 comments Download
M src/pkg/runtime/syscall_windows.goc View 1 2 3 4 5 6 7 8 9 10 11 12 13 7 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 37
aram
CC alex Some (trivial) windows changes in this one.
11 years ago (2013-12-02 20:44:45 UTC) #1
brainman
windows related code looks fine to me. But, please, ping me before submitting - I ...
11 years ago (2013-12-04 05:51:48 UTC) #2
aram
Hello alex.brainman@gmail.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
11 years ago (2013-12-10 20:40:03 UTC) #3
brainman
Build fails with: # ./all.bash # Building C bootstrap tool. cmd/dist # Building compilers and ...
11 years ago (2013-12-10 22:25:59 UTC) #4
dave_cheney.net
Thanks for reviewing this, if you apply https://codereview.appspot.com/35900045/ First, do it fix the problem? > ...
11 years ago (2013-12-10 22:47:20 UTC) #5
brainman
LGTM, but wait for others. All builds fine on both windows/386 and windows/amd64. Thank you. ...
11 years ago (2013-12-10 23:09:35 UTC) #6
brainman
I forgotten to publish my comments. Alex https://codereview.appspot.com/35990043/diff/190001/src/pkg/runtime/proc.c File src/pkg/runtime/proc.c (right): https://codereview.appspot.com/35990043/diff/190001/src/pkg/runtime/proc.c#newcode213 src/pkg/runtime/proc.c:213: // runtime·newproc1(&scavenger, ...
11 years ago (2013-12-10 23:10:06 UTC) #7
aram
Thanks, the CLs are not independent (as you have discovered). -- Aram Hăvărneanu
11 years ago (2013-12-10 23:27:57 UTC) #8
jsing
Doing this via cgo/libc seems to be the wrong approach, given that we have the ...
11 years ago (2013-12-11 03:40:06 UTC) #9
aram
Solaris is like windows. Direct system calls are not supported at all. In fact, it's ...
11 years ago (2013-12-11 11:12:11 UTC) #10
aram
On Wed, Dec 11, 2013 at 4:40 AM, <jsing@google.com> wrote: > it seems that this ...
11 years ago (2013-12-11 14:04:57 UTC) #11
aram
PTAL https://codereview.appspot.com/35990043/diff/190001/src/pkg/runtime/proc.c File src/pkg/runtime/proc.c (right): https://codereview.appspot.com/35990043/diff/190001/src/pkg/runtime/proc.c#newcode213 src/pkg/runtime/proc.c:213: // runtime·newproc1(&scavenger, nil, 0, 0, runtime·main); On 2013/12/10 ...
11 years ago (2013-12-12 15:11:56 UTC) #12
gobot
R=rsc@golang.org (assigned by alex.brainman@gmail.com)
10 years, 12 months ago (2013-12-20 05:20:09 UTC) #13
gobot
Replacing golang-dev with golang-codereviews.
10 years, 12 months ago (2013-12-20 16:26:09 UTC) #14
aram
Hello alex.brainman@gmail.com, dave@cheney.net, jsing@google.com, gobot@golang.org, rsc@golang.org (cc: golang-codereviews@googlegroups.com), Please take another look.
10 years, 12 months ago (2013-12-21 21:48:20 UTC) #15
aram
Hello alex.brainman@gmail.com, dave@cheney.net, jsing@google.com, gobot@golang.org, rsc@golang.org (cc: golang-codereviews@googlegroups.com), Please take another look.
10 years, 11 months ago (2013-12-29 17:44:41 UTC) #16
jsing
Please update any files that have been copied from an existing source, so that they ...
10 years, 11 months ago (2014-01-07 13:05:55 UTC) #17
aram
https://codereview.appspot.com/35990043/diff/330001/src/pkg/runtime/asm_amd64.s File src/pkg/runtime/asm_amd64.s (right): https://codereview.appspot.com/35990043/diff/330001/src/pkg/runtime/asm_amd64.s#newcode621 src/pkg/runtime/asm_amd64.s:621: MOVQ m_gsignal(BP), SI On 2014/01/07 13:05:56, jsing wrote: > ...
10 years, 11 months ago (2014-01-09 15:09:25 UTC) #18
aram
Hello alex.brainman@gmail.com, dave@cheney.net, jsing@google.com, gobot@golang.org, rsc@golang.org (cc: golang-codereviews@googlegroups.com), Please take another look.
10 years, 11 months ago (2014-01-09 15:10:13 UTC) #19
rsc
LGTM Leaving for jsing (thanks!) https://codereview.appspot.com/35990043/diff/370001/src/pkg/runtime/asm_amd64.s File src/pkg/runtime/asm_amd64.s (right): https://codereview.appspot.com/35990043/diff/370001/src/pkg/runtime/asm_amd64.s#newcode620 src/pkg/runtime/asm_amd64.s:620: JE nosave please use ...
10 years, 11 months ago (2014-01-09 23:51:07 UTC) #20
aram
Hello alex.brainman@gmail.com, dave@cheney.net, jsing@google.com, gobot@golang.org, rsc@golang.org (cc: golang-codereviews@googlegroups.com), Please take another look.
10 years, 11 months ago (2014-01-11 14:10:48 UTC) #21
aram
https://codereview.appspot.com/35990043/diff/370001/src/pkg/runtime/asm_amd64.s File src/pkg/runtime/asm_amd64.s (right): https://codereview.appspot.com/35990043/diff/370001/src/pkg/runtime/asm_amd64.s#newcode620 src/pkg/runtime/asm_amd64.s:620: JE nosave On 2014/01/09 23:51:08, rsc wrote: > please ...
10 years, 11 months ago (2014-01-11 14:10:51 UTC) #22
jsing
LGTM https://codereview.appspot.com/35990043/diff/410001/src/pkg/runtime/malloc.h File src/pkg/runtime/malloc.h (right): https://codereview.appspot.com/35990043/diff/410001/src/pkg/runtime/malloc.h#newcode553 src/pkg/runtime/malloc.h:553: void runtime_netpoll_scan(void (*)(Obj)); This is seemingly unused and ...
10 years, 11 months ago (2014-01-14 14:21:44 UTC) #23
jsing
LGTM
10 years, 11 months ago (2014-01-14 14:27:32 UTC) #24
aram
Hello alex.brainman@gmail.com, dave@cheney.net, jsing@google.com, gobot@golang.org, rsc@golang.org (cc: golang-codereviews@googlegroups.com), Please take another look.
10 years, 11 months ago (2014-01-16 13:48:48 UTC) #25
aram
https://codereview.appspot.com/35990043/diff/410001/src/pkg/runtime/malloc.h File src/pkg/runtime/malloc.h (right): https://codereview.appspot.com/35990043/diff/410001/src/pkg/runtime/malloc.h#newcode553 src/pkg/runtime/malloc.h:553: void runtime_netpoll_scan(void (*)(Obj)); On 2014/01/14 14:21:45, jsing wrote: > ...
10 years, 11 months ago (2014-01-16 13:49:15 UTC) #26
jsing
*** Submitted as https://code.google.com/p/go/source/detail?r=322f646feecb *** runtime: add support for GOOS=solaris R=alex.brainman, dave, jsing, gobot, rsc ...
10 years, 11 months ago (2014-01-17 04:59:31 UTC) #27
dave_cheney.net
\o/ Thanks! > On 17 Jan 2014, at 15:59, jsing@google.com wrote: > > *** Submitted ...
10 years, 11 months ago (2014-01-17 05:03:41 UTC) #28
dvyukov
https://codereview.appspot.com/35990043/diff/450001/src/pkg/runtime/lfstack.c File src/pkg/runtime/lfstack.c (right): https://codereview.appspot.com/35990043/diff/450001/src/pkg/runtime/lfstack.c#newcode23 src/pkg/runtime/lfstack.c:23: // Use low-order three bits as ABA counter. 3 ...
10 years, 11 months ago (2014-01-18 16:13:28 UTC) #29
aram
https://codereview.appspot.com/35990043/diff/450001/src/pkg/runtime/lfstack.c File src/pkg/runtime/lfstack.c (right): https://codereview.appspot.com/35990043/diff/450001/src/pkg/runtime/lfstack.c#newcode23 src/pkg/runtime/lfstack.c:23: // Use low-order three bits as ABA counter. On ...
10 years, 11 months ago (2014-01-18 16:14:48 UTC) #30
rsc
https://codereview.appspot.com/35990043/diff/450001/src/pkg/runtime/lfstack.c File src/pkg/runtime/lfstack.c (right): https://codereview.appspot.com/35990043/diff/450001/src/pkg/runtime/lfstack.c#newcode23 src/pkg/runtime/lfstack.c:23: // Use low-order three bits as ABA counter. How ...
10 years, 1 month ago (2014-11-04 03:51:54 UTC) #31
minux
https://codereview.appspot.com/35990043/diff/450001/src/pkg/runtime/lfstack.c File src/pkg/runtime/lfstack.c (right): https://codereview.appspot.com/35990043/diff/450001/src/pkg/runtime/lfstack.c#newcode23 src/pkg/runtime/lfstack.c:23: // Use low-order three bits as ABA counter. On ...
10 years, 1 month ago (2014-11-04 05:08:12 UTC) #32
aram
> I think that refers to the fact the Solaris kernel allocate part > of ...
10 years, 1 month ago (2014-11-04 09:55:04 UTC) #33
rsc
Thanks, that's easy to fix.
10 years, 1 month ago (2014-11-04 14:34:58 UTC) #34
gusev.vitaliy
Approach to check "errno" after syscall works so far, but for forkx() it can fail ...
6 years, 9 months ago (2018-03-01 17:23:13 UTC) #35
iant
On 2018/03/01 17:23:13, gusev.vitaliy wrote: You are replying to a patch that is three years ...
6 years, 9 months ago (2018-03-01 22:10:49 UTC) #36
fundasecgin32
5 months ago (2024-07-11 15:16:57 UTC) #37

          
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b