Issue 359720043: [plaso] Moved IsText from utils to text parser #1958

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 359720043: [plaso] Moved IsText from utils to text parser #1958 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
5 years, 10 months ago by Joachim Metz

Modified:
5 years, 10 months ago

Reviewers:
onager

CC:
kiddi, log2timeline-dev_googlegroups.com, romaing

Visibility:
Public.

[plaso] Moved IsText from utils to text parser #1958

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+90 lines, -108 lines)			Patch
D	plaso/lib/utils.py	View	1 chunk	+0 lines, -68 lines	0 comments	Download
M	plaso/parsers/text_parser.py	View	4 chunks	+62 lines, -3 lines	0 comments	Download
D	tests/lib/utils.py	View	1 chunk	+0 lines, -37 lines	0 comments	Download
M	tests/parsers/text_parser.py	View	1 chunk	+28 lines, -0 lines	0 comments	Download

Total messages: 2

onager

5 years, 10 months ago (2018-06-22 09:15:29 UTC) #2

On 2018/06/21 19:40:01, Joachim Metz wrote:

Reviewing on github